[ https://issues.apache.org/jira/browse/HIVE-25397?focusedWorklogId=664524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-664524 ]
ASF GitHub Bot logged work on HIVE-25397: ----------------------------------------- Author: ASF GitHub Bot Created on: 13/Oct/21 09:17 Start Date: 13/Oct/21 09:17 Worklog Time Spent: 10m Work Description: ArkoSharma commented on a change in pull request #2539: URL: https://github.com/apache/hive/pull/2539#discussion_r727865312 ########## File path: itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/parse/TestReplicationScenariosAcidTables.java ########## @@ -103,38 +109,49 @@ static void internalBeforeClassSetup(Map<String, String> overrides, conf.set("dfs.client.use.datanode.hostname", "true"); conf.set("metastore.warehouse.tenant.colocation", "true"); conf.set("hadoop.proxyuser." + Utils.getUGI().getShortUserName() + ".hosts", "*"); + String primaryBaseDir = Files.createTempDirectory("primary").toFile().getAbsolutePath(); + conf.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR, primaryBaseDir); + replicaConf = new HiveConf(clazz); + replicaConf.set("dfs.client.use.datanode.hostname", "true"); + replicaConf.set("metastore.warehouse.tenant.colocation", "true"); + replicaConf.set("hadoop.proxyuser." + Utils.getUGI().getShortUserName() + ".hosts", "*"); + String replicaBaseDir = Files.createTempDirectory("replica").toFile().getAbsolutePath(); + replicaConf.set(MiniDFSCluster.HDFS_MINIDFS_BASEDIR, replicaBaseDir); MiniDFSCluster miniDFSCluster = - new MiniDFSCluster.Builder(conf).numDataNodes(2).format(true).build(); + new MiniDFSCluster.Builder(conf).numDataNodes(2).format(true).build(); + MiniDFSCluster miniDFSClusterReplica = + new MiniDFSCluster.Builder(replicaConf).numDataNodes(2).format(true).build(); Map<String, String> acidEnableConf = new HashMap<String, String>() {{ - put("fs.defaultFS", miniDFSCluster.getFileSystem().getUri().toString()); - put("hive.support.concurrency", "true"); - put("hive.txn.manager", "org.apache.hadoop.hive.ql.lockmgr.DbTxnManager"); - put("hive.metastore.client.capability.check", "false"); - put("hive.repl.bootstrap.dump.open.txn.timeout", "1s"); - put("hive.strict.checks.bucketing", "false"); - put("hive.mapred.mode", "nonstrict"); - put("mapred.input.dir.recursive", "true"); - put("hive.metastore.disallow.incompatible.col.type.changes", "false"); - put("metastore.warehouse.tenant.colocation", "true"); - put("hive.in.repl.test", "true"); - put("hive.txn.readonly.enabled", "true"); - //HIVE-25267 - put(MetastoreConf.ConfVars.TXN_OPENTXN_TIMEOUT.getVarname(), "2000"); - put(HiveConf.ConfVars.REPL_RUN_DATA_COPY_TASKS_ON_TARGET.varname, "false"); - put(HiveConf.ConfVars.REPL_RETAIN_CUSTOM_LOCATIONS_FOR_DB_ON_TARGET.varname, "false"); - }}; + put("fs.defaultFS", miniDFSCluster.getFileSystem().getUri().toString()); + put("hive.support.concurrency", "true"); + put("hive.txn.manager", "org.apache.hadoop.hive.ql.lockmgr.DbTxnManager"); + put("hive.metastore.client.capability.check", "false"); + put("hive.repl.bootstrap.dump.open.txn.timeout", "1s"); + put("hive.strict.checks.bucketing", "false"); + put("hive.mapred.mode", "nonstrict"); + put("mapred.input.dir.recursive", "true"); + put("hive.metastore.disallow.incompatible.col.type.changes", "false"); + put("metastore.warehouse.tenant.colocation", "true"); + put("hive.in.repl.test", "true"); + put("hive.txn.readonly.enabled", "true"); Review comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 664524) Time Spent: 3h 10m (was: 3h) > Snapshot support for controlled failover > ---------------------------------------- > > Key: HIVE-25397 > URL: https://issues.apache.org/jira/browse/HIVE-25397 > Project: Hive > Issue Type: Bug > Reporter: Arko Sharma > Assignee: Arko Sharma > Priority: Major > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > In case the same locations are used for external tables on the source and > target, then the snapshots created during replication can be re-used during > reverse replication. This patch enables re-using the snapshots during > reverse replication using a configuration. -- This message was sent by Atlassian Jira (v8.3.4#803005)