[ https://issues.apache.org/jira/browse/HIVE-25625?focusedWorklogId=667821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667821 ]
ASF GitHub Bot logged work on HIVE-25625: ----------------------------------------- Author: ASF GitHub Bot Created on: 20/Oct/21 14:57 Start Date: 20/Oct/21 14:57 Worklog Time Spent: 10m Work Description: kgyrtkirk commented on a change in pull request #2732: URL: https://github.com/apache/hive/pull/2732#discussion_r732868243 ########## File path: testutils/ptest2/conf/deployed/master-mr2.properties ########## @@ -84,7 +84,7 @@ ut.itests.hive-unit.skipBatching=TestAcidOnTezWithSplitUpdate TestAcidOnTez Test unitTests.module.itests.qtest=itests.qtest ut.itests.qtest.batchSize=9 -ut.itests.qtest.skipBatching=TestCompareCliDriver TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver +ut.itests.qtest.skipBatching=TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver Review comment: we don't really need to take care of this....in fact we may simply remove this `ptest` and `ptest2` directories as well...they are just dead weight (you may include the removal of them in the next cleanup ticket/or separate) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 667821) Time Spent: 20m (was: 10m) > Drop TestCompareCliDriver and related code from tests > ----------------------------------------------------- > > Key: HIVE-25625 > URL: https://issues.apache.org/jira/browse/HIVE-25625 > Project: Hive > Issue Type: Task > Components: Testing Infrastructure > Reporter: Stamatis Zampetakis > Assignee: Stamatis Zampetakis > Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > The driver has been introduced back in 2015 (HIVE-6010) aiming to run queries > with vectorization on/off and comparing the results. However it didn't > receive much attention since then and currently only two queries are run with > this driver. > The majority of tests aiming to ensure vectorization works correctly use the > {{TestMiniLlapLocalCliDriver}} and run a query twice switching on/off the > necessary properties. > Summing up having the > [TestCompareCliDriver|https://github.com/apache/hive/blob/d521f149fade25f74e7ca28fa399103684a80580/itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestCompareCliDriver.java] > in the repo leads to extra code maintenance cost without significant benefit. -- This message was sent by Atlassian Jira (v8.3.4#803005)