[ https://issues.apache.org/jira/browse/HIVE-25594?focusedWorklogId=673061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-673061 ]
ASF GitHub Bot logged work on HIVE-25594: ----------------------------------------- Author: ASF GitHub Bot Created on: 02/Nov/21 10:19 Start Date: 02/Nov/21 10:19 Worklog Time Spent: 10m Work Description: kgyrtkirk commented on a change in pull request #2742: URL: https://github.com/apache/hive/pull/2742#discussion_r740914957 ########## File path: itests/util/src/main/java/org/apache/hadoop/hive/ql/externalDB/AbstractExternalDB.java ########## @@ -71,27 +59,8 @@ public ProcessResults(String stdout, String stderr, int rc) { } } - public static AbstractExternalDB initalizeExternalDB(String externalDBType) throws IOException { - AbstractExternalDB abstractExternalDB; - switch (externalDBType) { - case "mysql": - abstractExternalDB = new MySQLExternalDB(); - break; - case "postgres": - abstractExternalDB = new PostgresExternalDB(); - break; - default: - throw new IOException("unsupported external database type " + externalDBType); - } - return abstractExternalDB; - } - - public AbstractExternalDB(String externalDBType) { - this.externalDBType = externalDBType; - } - - protected String getDockerContainerName() { - return String.format("qtestExternalDB-%s", externalDBType); + private final String getDockerContainerName() { Review comment: sure; can be covered in a followup as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 673061) Time Spent: 1h 50m (was: 1h 40m) > Setup JDBC databases in tests via QT options > -------------------------------------------- > > Key: HIVE-25594 > URL: https://issues.apache.org/jira/browse/HIVE-25594 > Project: Hive > Issue Type: Improvement > Components: Testing Infrastructure > Reporter: Stamatis Zampetakis > Assignee: Stamatis Zampetakis > Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > The goal of this jira is to add a new QT option for setting up JDBC DBMS and > using it in qtests which need a JDBC endpoint up and running. It can be used > in tests with external JDBC tables, connectors, etc. > A sample file using the proposed option ({{qt:database}}) is shown below. > {code:sql} > --!qt:database:postgres:init_sript_1234.sql:cleanup_script_1234.sql > CREATE EXTERNAL TABLE country (name varchar(80)) > STORED BY 'org.apache.hive.storage.jdbc.JdbcStorageHandler' > TBLPROPERTIES ( > "hive.sql.database.type" = "POSTGRES", > "hive.sql.jdbc.driver" = "org.postgresql.Driver", > "hive.sql.jdbc.url" = "jdbc:postgresql://localhost:5432/qtestDB", > "hive.sql.dbcp.username" = "qtestuser", > "hive.sql.dbcp.password" = "qtestpassword", > "hive.sql.table" = "country"); > EXPLAIN CBO SELECT COUNT(*) from country; > SELECT COUNT(*) from country; > {code} > This builds upon HIVE-25423 but proposes to use JDBC datasources without the > need for a using a specific CLI driver. Furthermore, the proposed QT option > syntax allows using customised init/cleanup scripts for the JDBC datasource > per test. -- This message was sent by Atlassian Jira (v8.3.4#803005)