[
https://issues.apache.org/jira/browse/HIVE-25801?focusedWorklogId=706881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-706881
]
ASF GitHub Bot logged work on HIVE-25801:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jan/22 14:21
Start Date: 11/Jan/22 14:21
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on a change in pull request #2879:
URL: https://github.com/apache/hive/pull/2879#discussion_r782193090
##########
File path: ql/src/test/org/apache/hadoop/hive/ql/TestTxnNoBuckets.java
##########
@@ -833,10 +833,6 @@ public void testCompactStatsGather() throws Exception {
Assert.assertEquals("Unexpected number of compactions in history", 1,
resp.getCompactsSize());
Assert.assertEquals("Unexpected 0 compaction state",
TxnStore.CLEANING_RESPONSE, resp.getCompacts().get(0).getState());
Assert.assertTrue(resp.getCompacts().get(0).getHadoopJobId().startsWith("job_local"));
-
- //now check that stats were updated
- map = hms.getPartitionColumnStatistics("default","T", partNames, colNames,
Constants.HIVE_ENGINE);
Review comment:
should we check basic statistics here instead on colStat?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 706881)
Time Spent: 3h (was: 2h 50m)
> Custom queue settings is not honoured by Query based compaction StatsUpdater
> ----------------------------------------------------------------------------
>
> Key: HIVE-25801
> URL: https://issues.apache.org/jira/browse/HIVE-25801
> Project: Hive
> Issue Type: Bug
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> {{hive.compactor.job.queue}} config limits resources available for
> compaction, so users can limit the effects of compaction on the cluster.
> However this settings does not affect stats collection which uses Driver.
> HIVE-25595 is addressing the above issue for MR-based compaction. We need to
> incorporate the same thing for the Query-based compaction.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
