[ https://issues.apache.org/jira/browse/HIVE-24367?focusedWorklogId=707432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-707432 ]
ASF GitHub Bot logged work on HIVE-24367: ----------------------------------------- Author: ASF GitHub Bot Created on: 12/Jan/22 12:06 Start Date: 12/Jan/22 12:06 Worklog Time Spent: 10m Work Description: abstractdog commented on pull request #2771: URL: https://github.com/apache/hive/pull/2771#issuecomment-1010978261 left some minor comments could you please share what did you find in terms of performance improvement, with the example query like: ``` CREATE TABLE IF NOT EXISTS test (name String, value int); INSERT INTO test VALUES('K1',1); INSERT INTO test VALUES('K2',2); .. .. .. INSERT INTO test VALUES('K20000',2) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 707432) Time Spent: 1h 20m (was: 1h 10m) > Explore whether HiveAlterHandler::alterTable can be optimised for > non-partitioned tables > ---------------------------------------------------------------------------------------- > > Key: HIVE-24367 > URL: https://issues.apache.org/jira/browse/HIVE-24367 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 > Reporter: Rajesh Balamohan > Assignee: Harshit Gupta > Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > {color:#222222}Writing lots of delta in non-partitioned table creates runtime > issues, when lot of delta folders are present.{color} > {color:#222222} {color} > {color:#222222}Following code in HiveAlterHandler is invoked for every insert > operation. It computes {{{color} > {color:#222222}updateTableStatsSlow}} for every insert causing runtime > delays.{color} > {color:#222222} {color} > {noformat} > if (MetaStoreUtils.requireCalStats(null, null, newt, environmentContext) && > !isPartitionedTable) { > Database db = msdb.getDatabase(catName, newDbName); > assert(isReplicated == HiveMetaStore.HMSHandler.isDbReplicationTarget(db)); > // Update table stats. For partitioned table, we update stats in > alterPartition() > MetaStoreUtils.updateTableStatsSlow(db, newt, wh, false, true, > environmentContext); > } > {noformat} > {color:#222222}It would be good to explore whether only the newly added delta > can be listed for computing stats. This would avoid huge listing call during > stats collection.{color} > {color:#222222}e.g queries to repro{color} > {noformat} > CREATE TABLE IF NOT EXISTS test (name String, value int); > INSERT INTO test VALUES('K1',1); > INSERT INTO test VALUES('K2',2); > .. > .. > .. > INSERT INTO test VALUES('K20000',2) > {noformat} > -- This message was sent by Atlassian Jira (v8.20.1#820001)