[
https://issues.apache.org/jira/browse/HIVE-25871?focusedWorklogId=710433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-710433
]
ASF GitHub Bot logged work on HIVE-25871:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jan/22 11:47
Start Date: 18/Jan/22 11:47
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2948:
URL: https://github.com/apache/hive/pull/2948#discussion_r786672462
##########
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergMigration.java
##########
@@ -225,12 +226,15 @@ private void validateSd(Table hmsTable, String format) {
private void validateTblProps(Table hmsTable, boolean migrationSucceeded) {
String migratedProp =
hmsTable.getParameters().get(HiveIcebergMetaHook.MIGRATED_TO_ICEBERG);
String tableTypeProp =
hmsTable.getParameters().get(BaseMetastoreTableOperations.TABLE_TYPE_PROP);
+ String nameMappingProp =
hmsTable.getParameters().get(TableProperties.DEFAULT_NAME_MAPPING);
if (migrationSucceeded) {
Assert.assertTrue(Boolean.parseBoolean(migratedProp));
Assert.assertEquals(BaseMetastoreTableOperations.ICEBERG_TABLE_TYPE_VALUE.toUpperCase(),
tableTypeProp);
+ Assert.assertTrue(nameMappingProp != null && !nameMappingProp.isEmpty());
} else {
Assert.assertNull(migratedProp);
Assert.assertNotEquals(BaseMetastoreTableOperations.ICEBERG_TABLE_TYPE_VALUE.toUpperCase(),
tableTypeProp);
+ Assert.assertTrue(nameMappingProp == null);
Review comment:
nit: could use Assert.assertNull here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 710433)
Time Spent: 20m (was: 10m)
> Hive should set name mapping table property for migrated Iceberg tables
> -----------------------------------------------------------------------
>
> Key: HIVE-25871
> URL: https://issues.apache.org/jira/browse/HIVE-25871
> Project: Hive
> Issue Type: Bug
> Reporter: Zoltán Borók-Nagy
> Assignee: Zoltán Borók-Nagy
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Hive should set the name-mapping table property during table migration.
> It would be useful for [column
> projection|https://iceberg.apache.org/#spec/#column-projection] for files
> without field ids.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
