[ https://issues.apache.org/jira/browse/HIVE-25864?focusedWorklogId=711048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-711048 ]
ASF GitHub Bot logged work on HIVE-25864: ----------------------------------------- Author: ASF GitHub Bot Created on: 19/Jan/22 02:01 Start Date: 19/Jan/22 02:01 Worklog Time Spent: 10m Work Description: maheshk114 commented on a change in pull request #2943: URL: https://github.com/apache/hive/pull/2943#discussion_r787291853 ########## File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveFilterProjectTransposeRule.java ########## @@ -170,6 +171,7 @@ public void onMatch(RelOptRuleCall call) { if (HiveCalciteUtil.isDeterministicFuncWithSingleInputRef(newCondition, commonPartitionKeys)) { newPartKeyFilConds.add(newCondition); + isConversionDone = true; Review comment: I was also thinking that way to keep the code clean, But there will be two conversion ..one to check if its deterministic and one more for the projection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 711048) Time Spent: 0.5h (was: 20m) > Hive query optimisation creates wrong plan for predicate pushdown with > windowing function > ------------------------------------------------------------------------------------------ > > Key: HIVE-25864 > URL: https://issues.apache.org/jira/browse/HIVE-25864 > Project: Hive > Issue Type: Bug > Reporter: mahesh kumar behera > Assignee: mahesh kumar behera > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > In case of a query with windowing function, the deterministic predicates are > pushed down below the window function. Before pushing down, the predicate is > converted to refer the project operator values. But the same conversion is > done again while creating the project and thus causing wrong plan generation. -- This message was sent by Atlassian Jira (v8.20.1#820001)