[
https://issues.apache.org/jira/browse/HIVE-25814?focusedWorklogId=720181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720181
]
ASF GitHub Bot logged work on HIVE-25814:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/22 14:36
Start Date: 03/Feb/22 14:36
Worklog Time Spent: 10m
Work Description: ayushtkn commented on a change in pull request #2907:
URL: https://github.com/apache/hive/pull/2907#discussion_r798610011
##########
File path: common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java
##########
@@ -614,7 +614,6 @@
SPARK_JOB_RUNTIME_ERROR(40001, "Spark job failed due to: {0}", true),
SPARK_TASK_RUNTIME_ERROR(40002, "Spark job failed due to task failures:
{0}", true),
- REPL_DATABASE_IS_TARGET_OF_REPLICATION(40003, "Cannot dump database as it is
a Target of replication."),
Review comment:
Unrelated to the change, we are doing here, can avoid this
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/util/ReplUtils.java
##########
@@ -474,4 +475,17 @@ public static void addLoggerTask(ReplLogger replLogger,
List<Task<?>> tasks, Hiv
DAGTraversal.traverse(tasks, new
AddDependencyToLeaves(Collections.singletonList(task)));
}
}
+
+ public static void reportStatusInReplicationMetrics(String stageName, Status
status, String errorLogPath,
+ HiveConf conf)
+ throws SemanticException {
+ GenericMetricCollector metricCollector = new GenericMetricCollector(0,
conf);
Review comment:
What advantage is ``GenericMetricCollector`` class giving you?
It is just calling the super constructor with pre-set value, that you could
do it here itself. Or by having a Constructor in the parent class which takes
only two params and set other values as ``null``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 720181)
Remaining Estimate: 0h
Time Spent: 10m
> Add entry in replication_metrics table for skipped replication iterations.
> --------------------------------------------------------------------------
>
> Key: HIVE-25814
> URL: https://issues.apache.org/jira/browse/HIVE-25814
> Project: Hive
> Issue Type: Improvement
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
