[
https://issues.apache.org/jira/browse/HIVE-25750?focusedWorklogId=721311&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721311
]
ASF GitHub Bot logged work on HIVE-25750:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/22 01:06
Start Date: 05/Feb/22 01:06
Worklog Time Spent: 10m
Work Description: hsnusonic commented on a change in pull request #2824:
URL: https://github.com/apache/hive/pull/2824#discussion_r799909665
##########
File path: beeline/pom.xml
##########
@@ -233,6 +233,53 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <descriptorRefs>
+ <descriptorRef>jar-with-dependencies</descriptorRef>
+ </descriptorRefs>
+ <finalName>jar-with-dependencies</finalName>
+ <transformers>
+ <transformer
implementation="com.github.edwgiz.mavenShadePlugin.log4j2CacheTransformer.PluginsCacheFileTransformer"
/>
+ <transformer
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
Review comment:
Could you check if we need this? The latest example in
https://github.com/edwgiz/maven-shaded-log4j-transformer doesn't have this
manifest resource transformer.
##########
File path: beeline/pom.xml
##########
@@ -233,6 +233,53 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <descriptorRefs>
+ <descriptorRef>jar-with-dependencies</descriptorRef>
+ </descriptorRefs>
+ <finalName>jar-with-dependencies</finalName>
Review comment:
Could you help me to understand how this name is used? What is the name
of the output jar?
##########
File path: beeline/pom.xml
##########
@@ -233,6 +233,53 @@
</execution>
</executions>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <descriptorRefs>
+ <descriptorRef>jar-with-dependencies</descriptorRef>
+ </descriptorRefs>
+ <finalName>jar-with-dependencies</finalName>
+ <transformers>
+ <transformer
implementation="com.github.edwgiz.mavenShadePlugin.log4j2CacheTransformer.PluginsCacheFileTransformer"
/>
+ <transformer
implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
+ <mainClass>org.openjdk.jmh.Main</mainClass>
+ </transformer>
+ </transformers>
+ <filters>
+ <filter>
+ <!--
+ Shading signed JARs will fail without this.
+
http://stackoverflow.com/questions/999489/invalid-signature-file-when-attempting-to-run-a-jar
+ -->
+ <artifact>*:*</artifact>
+ <excludes>
+ <exclude>META-INF/*.SF</exclude>
+ <exclude>META-INF/*.DSA</exclude>
+ <exclude>META-INF/*.RSA</exclude>
+ </excludes>
+ </filter>
+ </filters>
+ </configuration>
+ </execution>
+ </executions>
+ <dependencies>
+ <dependency>
+ <groupId>com.github.edwgiz</groupId>
+
<artifactId>maven-shade-plugin.log4j2-cachefile-transformer</artifactId>
+ <version>2.1</version>
Review comment:
It seems this package is specific to a log4j version. Given that hive
currently upgraded to 2.17.1, we might need to update the version here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 721311)
Time Spent: 1h 10m (was: 1h)
> Beeline: Creating a standalone tarball by isolating dependencies
> ----------------------------------------------------------------
>
> Key: HIVE-25750
> URL: https://issues.apache.org/jira/browse/HIVE-25750
> Project: Hive
> Issue Type: Bug
> Reporter: Abhay
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The code to create a standalone beeline tarball was created as part of this
> ticket https://issues.apache.org/jira/browse/HIVE-24348. However, a bug was
> reported in the case when the beeline is tried to install without the hadoop
> installed.
> The beeline script complains of missing dependencies when it is run.
> The ask as part of this ticket is to fix that bug.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
