[
https://issues.apache.org/jira/browse/HIVE-25895?focusedWorklogId=725901&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-725901
]
ASF GitHub Bot logged work on HIVE-25895:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/22 02:26
Start Date: 14/Feb/22 02:26
Worklog Time Spent: 10m
Work Description: pkumarsinha commented on a change in pull request #2980:
URL: https://github.com/apache/hive/pull/2980#discussion_r805413504
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadWork.java
##########
@@ -136,8 +142,9 @@ public ReplLoadWork(HiveConf hiveConf, String dumpDirectory,
FileSystem fs = failoverReadyMarker.getFileSystem(hiveConf);
shouldFailover =
hiveConf.getBoolVar(HiveConf.ConfVars.HIVE_REPL_FAILOVER_START)
&& fs.exists(failoverReadyMarker);
- isFailover =
- checkFileExists(new Path(dumpDirectory).getParent(), hiveConf,
OptimisedBootstrapUtils.EVENT_ACK_FILE);
+ isFirstFailover = checkFileExists(new Path(dumpDirectory).getParent(),
hiveConf, EVENT_ACK_FILE);
Review comment:
nit: Could create and re-use the Path object. e.g
Path dumpDirParent = new Path(dumpDirectory).getParent();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 725901)
Time Spent: 1h 40m (was: 1.5h)
> Bootstrap tables in table_diff during Incremental Load
> ------------------------------------------------------
>
> Key: HIVE-25895
> URL: https://issues.apache.org/jira/browse/HIVE-25895
> Project: Hive
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Consume the table_diff_ack file and do a bootstrap dump & load for those
> tables
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
