[
https://issues.apache.org/jira/browse/HIVE-26059?focusedWorklogId=747126&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747126
]
ASF GitHub Bot logged work on HIVE-26059:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Mar/22 11:12
Start Date: 24/Mar/22 11:12
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #3127:
URL: https://github.com/apache/hive/pull/3127#discussion_r834189474
##########
File path:
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -417,6 +417,10 @@ public static ConfVars getMetaConf(String name) {
"hive.compactor.history.retention.succeeded", 3,
new RangeValidator(0, 100), "Determines how many successful compaction
records will be " +
"retained in compaction history for a given table/partition."),
+
COMPACTOR_HISTORY_RETENTION_REFUSED("metastore.compactor.history.retention.refused",
+ "hive.compactor.history.retention.refused", 3,
+ new RangeValidator(0, 100), "Determines how many refused compaction
records will be " +
+ "retained in compaction history for a given table/partition."),
COMPACTOR_HISTORY_RETENTION_TIMEOUT("metastore.compactor.history.retention.timeout",
"hive.compactor.history.retention.timeout", 7, TimeUnit.DAYS,
"Determines how long failed and not initiated compaction records
will be " +
Review comment:
"Refused" should be listed here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 747126)
Time Spent: 1h 10m (was: 1h)
> Eventually clean compactions in "refused" state from compaction history
> -----------------------------------------------------------------------
>
> Key: HIVE-26059
> URL: https://issues.apache.org/jira/browse/HIVE-26059
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Compactions in states succeeded, failed, and did not initiate have a
> retention threshold (example:
> metastore.compactor.history.retention.succeeded) and are purged from
> COMPLETED_COMPACTIONS if the number of compactions in this state per
> partition/unpartitioned table passes the threshold. This keeps the size of
> COMPLETED_COMPACTIONS in check.
> We should also purge refused compactions from COMPLETED_COMPACTIONS.
> See:
> CompactionTxnHandler#purgeCompactionHistory
> ! Also: REFUSED_RESPONSE should be added to
> org.apache.hadoop.hive.metastore.txn.TxnStore#COMPACTION_STATES so that
> metrics will be collected about it.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
