[ https://issues.apache.org/jira/browse/HIVE-26093?focusedWorklogId=753912&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-753912 ]
ASF GitHub Bot logged work on HIVE-26093: ----------------------------------------- Author: ASF GitHub Bot Created on: 07/Apr/22 08:57 Start Date: 07/Apr/22 08:57 Worklog Time Spent: 10m Work Description: zabetak commented on code in PR #3168: URL: https://github.com/apache/hive/pull/3168#discussion_r844887792 ########## standalone-metastore/metastore-server/pom.xml: ########## @@ -474,23 +474,6 @@ </target> </configuration> </execution> - <execution> - <id>generate-version-annotation</id> - <phase>generate-sources</phase> - <configuration> - <target> - <exec executable="bash" failonerror="true"> - <arg value="${basedir}/src/main/resources/saveVersion.sh"/> - <arg value="${project.version}"/> - <arg value="${hive.version.shortname}"/> - <arg value="${basedir}/src"/> - </exec> - </target> - </configuration> - <goals> - <goal>run</goal> - </goals> - </execution> Review Comment: Do we know why was this introduced in the first place and if it is safe to remove? If I understood well this is the main point of the fix, can you confirm? ########## standalone-metastore/pom.xml: ########## @@ -531,6 +531,30 @@ </os> </activation> </profile> + <profile> + <id>javadoc</id> + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-javadoc-plugin</artifactId> + <configuration> + <doclint>none</doclint> + <additionalparam>-Xdoclint:none</additionalparam> Review Comment: Do we need both? ########## pom.xml: ########## @@ -1810,6 +1810,7 @@ <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-javadoc-plugin</artifactId> <configuration> + <doclint>none</doclint> <additionalparam>-Xdoclint:none</additionalparam> Review Comment: Is this change mandatory for building javadocs? Aren't these two lines somewhat equivalent? Why do we need both? Issue Time Tracking ------------------- Worklog Id: (was: 753912) Time Spent: 0.5h (was: 20m) > Deduplicate org.apache.hadoop.hive.metastore.annotation package-info.java > ------------------------------------------------------------------------- > > Key: HIVE-26093 > URL: https://issues.apache.org/jira/browse/HIVE-26093 > Project: Hive > Issue Type: Task > Reporter: Peter Vary > Assignee: Peter Vary > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently we define > org.apache.hadoop.hive.metastore.annotation.MetastoreVersionAnnotation in 2 > places: > - > ./standalone-metastore/metastore-common/src/gen/version/org/apache/hadoop/hive/metastore/annotation/package-info.java > - > ./standalone-metastore/metastore-server/src/gen/version/org/apache/hadoop/hive/metastore/annotation/package-info.java > This causes javadoc generation to fail with: > {code} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:aggregate (default-cli) > on project hive: An error has occurred in Javadoc report generation: > [ERROR] Exit code: 1 - > /Users/pvary/dev/upstream/hive/standalone-metastore/metastore-server/src/gen/version/org/apache/hadoop/hive/metastore/annotation/package-info.java:8: > warning: a package-info.java file has already been seen for package > org.apache.hadoop.hive.metastore.annotation > [ERROR] package org.apache.hadoop.hive.metastore.annotation; > [ERROR] ^ > [ERROR] javadoc: warning - Multiple sources of package comments found for > package "org.apache.hive.streaming" > [ERROR] > /Users/pvary/dev/upstream/hive/ql/src/java/org/apache/hadoop/hive/ql/exec/SerializationUtilities.java:556: > error: type MapSerializer does not take parameters > [ERROR] com.esotericsoftware.kryo.serializers.MapSerializer<Map> { > [ERROR] ^ > [ERROR] > /Users/pvary/dev/upstream/hive/standalone-metastore/metastore-server/src/gen/version/org/apache/hadoop/hive/metastore/annotation/package-info.java:4: > error: package org.apache.hadoop.hive.metastore.annotation has already been > annotated > [ERROR] @MetastoreVersionAnnotation(version="4.0.0-alpha-1", > shortVersion="4.0.0-alpha-1", > [ERROR] ^ > [ERROR] java.lang.AssertionError > [ERROR] at com.sun.tools.javac.util.Assert.error(Assert.java:126) > [ERROR] at com.sun.tools.javac.util.Assert.check(Assert.java:45) > [ERROR] at > com.sun.tools.javac.code.SymbolMetadata.setDeclarationAttributesWithCompletion(SymbolMetadata.java:177) > [ERROR] at > com.sun.tools.javac.code.Symbol.setDeclarationAttributesWithCompletion(Symbol.java:215) > [ERROR] at > com.sun.tools.javac.comp.MemberEnter.actualEnterAnnotations(MemberEnter.java:952) > [ERROR] at > com.sun.tools.javac.comp.MemberEnter.access$600(MemberEnter.java:64) > [ERROR] at > com.sun.tools.javac.comp.MemberEnter$5.run(MemberEnter.java:876) > [ERROR] at com.sun.tools.javac.comp.Annotate.flush(Annotate.java:143) > [ERROR] at > com.sun.tools.javac.comp.Annotate.enterDone(Annotate.java:129) > [ERROR] at com.sun.tools.javac.comp.Enter.complete(Enter.java:512) > [ERROR] at com.sun.tools.javac.comp.Enter.main(Enter.java:471) > [ERROR] at com.sun.tools.javadoc.JavadocEnter.main(JavadocEnter.java:78) > [ERROR] at > com.sun.tools.javadoc.JavadocTool.getRootDocImpl(JavadocTool.java:186) > [ERROR] at com.sun.tools.javadoc.Start.parseAndExecute(Start.java:346) > [ERROR] at com.sun.tools.javadoc.Start.begin(Start.java:219) > [ERROR] at com.sun.tools.javadoc.Start.begin(Start.java:205) > [ERROR] at com.sun.tools.javadoc.Main.execute(Main.java:64) > [ERROR] at com.sun.tools.javadoc.Main.main(Main.java:54) > [ERROR] javadoc: error - fatal error > [ERROR] > [ERROR] Command line was: > /usr/local/Cellar/openjdk@8/1.8.0+302/libexec/openjdk.jdk/Contents/Home/jre/../bin/javadoc > @options @packages > [ERROR] > [ERROR] Refer to the generated Javadoc files in > '/Users/pvary/dev/upstream/hive/target/site/apidocs' dir. > {code} > We should fix this by removing one of the above -- This message was sent by Atlassian Jira (v8.20.1#820001)