[ 
https://issues.apache.org/jira/browse/HIVE-26102?focusedWorklogId=755228&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755228
 ]

ASF GitHub Bot logged work on HIVE-26102:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/22 13:39
            Start Date: 11/Apr/22 13:39
    Worklog Time Spent: 10m 
      Work Description: marton-bod commented on code in PR #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r847339367


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java:
##########
@@ -673,7 +674,31 @@ private String toErrorMessage(Writable value, Object row, 
ObjectInspector inspec
             ctx.getIoCxt().setRecordIdentifier(null);//so we don't 
accidentally cache the value; shouldn't
             //happen since IO layer either knows how to produce ROW__ID or not 
- but to be safe
           }
-         break;
+          break;
+        case PARTITION_SPEC_ID:

Review Comment:
   Unfortunately we don't have the Table object anywhere around this area as 
far as I can tell, so I'm not sure how we could inject the logic using the 
storage handler. Besides, this method is called `populateVirtualColumns` where 
all the other virtual cols are filled out too, so right now I don't see a 
better place to put it





Issue Time Tracking
-------------------

    Worklog Id:     (was: 755228)
    Time Spent: 16h 20m  (was: 16h 10m)

> Implement DELETE statements for Iceberg tables
> ----------------------------------------------
>
>                 Key: HIVE-26102
>                 URL: https://issues.apache.org/jira/browse/HIVE-26102
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: Marton Bod
>            Assignee: Marton Bod
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 16h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to