[
https://issues.apache.org/jira/browse/HIVE-25091?focusedWorklogId=757229&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-757229
]
ASF GitHub Bot logged work on HIVE-25091:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/22 21:37
Start Date: 14/Apr/22 21:37
Worklog Time Spent: 10m
Work Description: nrg4878 commented on code in PR #3167:
URL: https://github.com/apache/hive/pull/3167#discussion_r850828206
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MSSQLConnectorProvider.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore.dataconnector.jdbc;
+
+import org.apache.hadoop.hive.metastore.ColumnType;
+import org.apache.hadoop.hive.metastore.api.DataConnector;
+import org.apache.hadoop.hive.metastore.api.MetaException;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.sql.ResultSet;
+import java.sql.SQLException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class MSSQLConnectorProvider extends AbstractJDBCConnectorProvider {
+ private static Logger LOG =
LoggerFactory.getLogger(MySQLConnectorProvider.class);
Review Comment:
missed this the first time around. But incorrect classname here.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/AbstractJDBCConnectorProvider.java:
##########
@@ -220,6 +224,8 @@ protected Connection getConnection() {
rs = fetchColumnsViaDBMetaData(tableName);
List<FieldSchema> cols = new ArrayList<>();
while (rs.next()) {
+ String datatype = rs.getString("DATA_TYPE");
Review Comment:
these 2 do not appear to be in use. Was it your intent to use one of them in
the setType()
Issue Time Tracking
-------------------
Worklog Id: (was: 757229)
Time Spent: 1.5h (was: 1h 20m)
> Implement connector provider for MSSQL and Oracle
> -------------------------------------------------
>
> Key: HIVE-25091
> URL: https://issues.apache.org/jira/browse/HIVE-25091
> Project: Hive
> Issue Type: Sub-task
> Reporter: Sai Hemanth Gantasala
> Assignee: Sai Hemanth Gantasala
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Provide an implementation of Connector provider for MSSQL and Oracle
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
