[ 
https://issues.apache.org/jira/browse/HIVE-26149?focusedWorklogId=761630&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-761630
 ]

ASF GitHub Bot logged work on HIVE-26149:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Apr/22 07:53
            Start Date: 25/Apr/22 07:53
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3220:
URL: https://github.com/apache/hive/pull/3220#discussion_r857350352


##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java:
##########
@@ -1685,7 +1688,89 @@ public void testDropWithBaseMultiplePartitions() throws 
Exception {
       }
     }
   }
+  
+  @Test
+  public void testDropDatabaseCascadePerTableNonBlocking() throws Exception {
+    MetastoreConf.setLongVar(hiveConf, 
MetastoreConf.ConfVars.BATCH_RETRIEVE_MAX, 1);
+    dropDatabaseCascadeNonBlocking();
+  }
+  @Test
+  public void testDropDatabaseCascadePerDbNonBlocking() throws Exception {
+    dropDatabaseCascadeNonBlocking();
+  }
+  private void dropDatabaseCascadeNonBlocking() throws Exception {

Review Comment:
   Nit: newline



##########
ql/src/test/org/apache/hadoop/hive/ql/TestTxnCommands.java:
##########
@@ -1685,7 +1688,89 @@ public void testDropWithBaseMultiplePartitions() throws 
Exception {
       }
     }
   }
+  
+  @Test
+  public void testDropDatabaseCascadePerTableNonBlocking() throws Exception {
+    MetastoreConf.setLongVar(hiveConf, 
MetastoreConf.ConfVars.BATCH_RETRIEVE_MAX, 1);
+    dropDatabaseCascadeNonBlocking();
+  }
+  @Test

Review Comment:
   Nit: newline





Issue Time Tracking
-------------------

    Worklog Id:     (was: 761630)
    Time Spent: 40m  (was: 0.5h)

> Non blocking DROP DATABASE implementation
> -----------------------------------------
>
>                 Key: HIVE-26149
>                 URL: https://issues.apache.org/jira/browse/HIVE-26149
>             Project: Hive
>          Issue Type: Task
>            Reporter: Denys Kuzmenko
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to