[ 
https://issues.apache.org/jira/browse/HIVE-26203?focusedWorklogId=767865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-767865
 ]

ASF GitHub Bot logged work on HIVE-26203:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/May/22 11:14
            Start Date: 09/May/22 11:14
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3270:
URL: https://github.com/apache/hive/pull/3270#discussion_r867899800


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -336,6 +336,30 @@ public void 
preAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable, E
       // that users can change data types or reorder columns too with this 
alter op type, so its name is misleading..)
       assertNotMigratedTable(hmsTable.getParameters(), "CHANGE COLUMN");
       handleChangeColumn(hmsTable);
+    } else if (AlterTableType.ADDPROPS.equals(currentAlterTableOp)) {
+      assertNotThirdPartyMetadataLocationChange(hmsTable.getParameters());

Review Comment:
   nit: `crossTableMetadataLocationChange`?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 767865)
    Time Spent: 20m  (was: 10m)

> Implement alter iceberg table metadata location
> -----------------------------------------------
>
>                 Key: HIVE-26203
>                 URL: https://issues.apache.org/jira/browse/HIVE-26203
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: iceberg, pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to