[ 
https://issues.apache.org/jira/browse/HIVE-25872?focusedWorklogId=769964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769964
 ]

ASF GitHub Bot logged work on HIVE-25872:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/May/22 00:21
            Start Date: 13/May/22 00:21
    Worklog Time Spent: 10m 
      Work Description: rbalamohan commented on code in PR #2950:
URL: https://github.com/apache/hive/pull/2950#discussion_r871907679


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java:
##########
@@ -284,6 +285,19 @@ public static boolean checkIfDbNeedsToBeSkipped(Database 
db) {
     return false;
   }
 
+  public static List<String> getReplicationDbProps() {
+    return Arrays.stream(ReplConst.class.getDeclaredFields())
+            .filter(field -> Modifier.isStatic(field.getModifiers()))
+            .map(field -> {
+              try {
+                String prop = (String) field.get(String.class);
+                return prop.replace("\"", "");
+              } catch (IllegalAccessException e) {
+                throw new RuntimeException(e);

Review Comment:
   Log and add details about the reason for the error?



##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java:
##########
@@ -284,6 +285,19 @@ public static boolean checkIfDbNeedsToBeSkipped(Database 
db) {
     return false;
   }
 
+  public static List<String> getReplicationDbProps() {
+    return Arrays.stream(ReplConst.class.getDeclaredFields())
+            .filter(field -> Modifier.isStatic(field.getModifiers()))
+            .map(field -> {
+              try {
+                String prop = (String) field.get(String.class);
+                return prop.replace("\"", "");
+              } catch (IllegalAccessException e) {
+                throw new RuntimeException(e);

Review Comment:
   Log and add details about the reason for the error for easier debugging?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 769964)
    Time Spent: 1h  (was: 50m)

> Skip tracking of alterDatabase events for replication specific properties.
> --------------------------------------------------------------------------
>
>                 Key: HIVE-25872
>                 URL: https://issues.apache.org/jira/browse/HIVE-25872
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Haymant Mangla
>            Assignee: Haymant Mangla
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to