[ https://issues.apache.org/jira/browse/HIVE-26228?focusedWorklogId=770709&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-770709 ]
ASF GitHub Bot logged work on HIVE-26228: ----------------------------------------- Author: ASF GitHub Bot Created on: 16/May/22 09:01 Start Date: 16/May/22 09:01 Worklog Time Spent: 10m Work Description: pvary commented on code in PR #3287: URL: https://github.com/apache/hive/pull/3287#discussion_r873488810 ########## iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java: ########## @@ -425,6 +425,15 @@ public void commitAlterTable(org.apache.hadoop.hive.metastore.api.Table hmsTable case SETPARTITIONSPEC: IcebergTableUtil.updateSpec(conf, icebergTable); break; + case ROLLBACK: + LOG.info("Executing rollback operation on iceberg table. If you would like to revert rollback you could " + Review Comment: If I understand correctly a `rollback` operation just adds a new snapshot at the end of the history. So if we want to roll back a rollback, then we just have to do another rollback. If the above is true, then I think it would be easier for the user to understand Issue Time Tracking ------------------- Worklog Id: (was: 770709) Time Spent: 0.5h (was: 20m) > Implement Iceberg table rollback feature > ---------------------------------------- > > Key: HIVE-26228 > URL: https://issues.apache.org/jira/browse/HIVE-26228 > Project: Hive > Issue Type: New Feature > Reporter: László Pintér > Assignee: László Pintér > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > We should allow rolling back iceberg table's data to the state at an older > table snapshot. > Rollback to the last snapshot before a specific timestamp > {code:java} > ALTER TABLE ice_t EXECUTE ROLLBACK('2022-05-12 00:00:00') > {code} > Rollback to a specific snapshot ID > {code:java} > ALTER TABLE ice_t EXECUTE ROLLBACK(1111); > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007)