[ 
https://issues.apache.org/jira/browse/HIVE-26228?focusedWorklogId=774432&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774432
 ]

ASF GitHub Bot logged work on HIVE-26228:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/May/22 09:06
            Start Date: 25/May/22 09:06
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3287:
URL: https://github.com/apache/hive/pull/3287#discussion_r881411074


##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java:
##########
@@ -379,4 +382,23 @@ public static DeleteFile createPositionalDeleteFile(Table 
table, String deleteFi
     return posWriter.toDeleteFile();
   }
 
+  /**
+   * Get the timestamp string which we can use in the queries. The timestamp 
will be after the given snapshot
+   * and before the next one
+   * @param table The table which we want to query
+   * @param snapshotPosition The position of the last snapshot we want to see 
in the query results
+   * @return The timestamp which we can use in the queries
+   */
+  public static String timestampAfterSnapshot(Table table, int 
snapshotPosition) {

Review Comment:
   Never mind, I see you just refactored this :)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 774432)
    Time Spent: 3h 20m  (was: 3h 10m)

> Implement Iceberg table rollback feature
> ----------------------------------------
>
>                 Key: HIVE-26228
>                 URL: https://issues.apache.org/jira/browse/HIVE-26228
>             Project: Hive
>          Issue Type: New Feature
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> We should allow rolling back iceberg table's data to the state at an older 
> table snapshot. 
> Rollback to the last snapshot before a specific timestamp
> {code:java}
> ALTER TABLE ice_t EXECUTE ROLLBACK('2022-05-12 00:00:00')
> {code}
> Rollback to a specific snapshot ID
> {code:java}
>  ALTER TABLE ice_t EXECUTE ROLLBACK(1111); 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to