[ 
https://issues.apache.org/jira/browse/HIVE-26261?focusedWorklogId=774945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-774945
 ]

ASF GitHub Bot logged work on HIVE-26261:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/May/22 08:42
            Start Date: 26/May/22 08:42
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3320:
URL: https://github.com/apache/hive/pull/3320#discussion_r882453126


##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/command/CommandAuthorizerV2.java:
##########
@@ -158,6 +158,15 @@ private static boolean isDeferredAuthView(Table t){
     if (TableType.MATERIALIZED_VIEW.name().equals(tableType) || 
TableType.VIRTUAL_VIEW.name().equals(tableType)) {
       isView = true;
     }
+    if (isView) {
+      Map<String, String> params = t.getParameters();
+      if (params != null && params.containsKey(authorizedKeyword)) {

Review Comment:
   In theory this could be used by any other system.
   In reality, yes :(





Issue Time Tracking
-------------------

    Worklog Id:     (was: 774945)
    Time Spent: 40m  (was: 0.5h)

> Fix some issues with Spark engine removal
> -----------------------------------------
>
>                 Key: HIVE-26261
>                 URL: https://issues.apache.org/jira/browse/HIVE-26261
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Peter Vary
>            Assignee: Peter Vary
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> I have made some mistakes when removed the Spark code:
>  * CommandAuthorizerV2.java - should check the properties. At that stage the 
> authorizer was referring tables created by Spark as a HMS client, and not as 
> an engine
>  * There is one unused method left in MapJoinTableContainerSerDe.java



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to