[ 
https://issues.apache.org/jira/browse/HIVE-24484?focusedWorklogId=776171&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776171
 ]

ASF GitHub Bot logged work on HIVE-24484:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/May/22 09:26
            Start Date: 31/May/22 09:26
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on code in PR #3279:
URL: https://github.com/apache/hive/pull/3279#discussion_r885363228


##########
ql/src/test/queries/clientpositive/acid_table_directories_test.q:
##########
@@ -1,3 +1,5 @@
+--! qt:disabled:disabled Tests the output of LS and that changes, Not a 
functional test, just adds some masking logic

Review Comment:
   you may also remove this test....and/or open a jira to remove the things 
which were added in HIVE-21650;
   I think `qt:replace` could do the same..
   
   hmm...it seems like `hive.qtest.additional.partial.mask.pattern` is only 
used in this test and nowhere else...



##########
ql/src/test/results/clientpositive/llap/acid_table_directories_test.q.out:
##########
@@ -163,13 +170,6 @@ POSTHOOK: Input: default@acidparttbl@p=200
 ### ACID DELTA DIR ###
 ### ACID DELTA DIR ###
 ### ACID DELTA DIR ###
-#### A masked pattern was here ####

Review Comment:
   I would guess the directory listing order might have changed...
   
   note: I think we should have better masking policies instead of removing the 
whole lines (mask only the WH part of the path)...it could be important what 
was the directory...





Issue Time Tracking
-------------------

    Worklog Id:     (was: 776171)
    Time Spent: 11.55h  (was: 11h 23m)

> Upgrade Hadoop to 3.3.1
> -----------------------
>
>                 Key: HIVE-24484
>                 URL: https://issues.apache.org/jira/browse/HIVE-24484
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 11.55h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to