[
https://issues.apache.org/jira/browse/HIVE-1626?focusedWorklogId=795795&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795795
]
ASF GitHub Bot logged work on HIVE-1626:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/22 18:43
Start Date: 27/Jul/22 18:43
Worklog Time Spent: 10m
Work Description: cmunkey commented on PR #3441:
URL: https://github.com/apache/hive/pull/3441#issuecomment-1197224233
java.util.Stack uses equals() for search, so maybe it is appropriate to use
equals here for indexOf().
public synchronized int search(Object o)
Issue Time Tracking
-------------------
Worklog Id: (was: 795795)
Time Spent: 1h 50m (was: 1h 40m)
> stop using java.util.Stack
> --------------------------
>
> Key: HIVE-1626
> URL: https://issues.apache.org/jira/browse/HIVE-1626
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 0.7.0
> Reporter: John Sichi
> Assignee: Teddy Choi
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-1626.2.patch, HIVE-1626.2.patch, HIVE-1626.3.patch,
> HIVE-1626.3.patch, HIVE-1626.3.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We currently use Stack as part of the generic node walking library. Stack
> should not be used for this since its inheritance from Vector incurs
> superfluous synchronization overhead.
> Most projects end up adding an ArrayStack implementation and using that
> instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
