[
https://issues.apache.org/jira/browse/HIVE-26479?focusedWorklogId=803852&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-803852
]
ASF GitHub Bot logged work on HIVE-26479:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/22 06:41
Start Date: 26/Aug/22 06:41
Worklog Time Spent: 10m
Work Description: SourabhBadhya commented on code in PR #3528:
URL: https://github.com/apache/hive/pull/3528#discussion_r955707999
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/QueryCompactor.java:
##########
@@ -272,5 +278,16 @@ static void removeFilesForMmTable(HiveConf conf,
AcidDirectory dir) throws IOExc
fs.delete(dead, true);
}
}
+
+ static void overrideConfProps(HiveConf conf, CompactionInfo ci,
Map<String, String> properties) {
+ Stream.of(properties, ci.properties != null ? new
StringableMap(ci.properties) : null)
Review Comment:
Removed the following file -
https://github.com/apache/hive/blob/master/common/src/java/org/apache/hadoop/hive/common/StringableMap.java
However, regarding the behaviour of toString wherein null is given a length
of -1. I have retained the same behaviour moving forward mainly because of
[HIVE-17391](https://issues.apache.org/jira/browse/HIVE-17391).
Issue Time Tracking
-------------------
Worklog Id: (was: 803852)
Time Spent: 3h (was: 2h 50m)
> Add ability to set parameters for query-based compaction
> --------------------------------------------------------
>
> Key: HIVE-26479
> URL: https://issues.apache.org/jira/browse/HIVE-26479
> Project: Hive
> Issue Type: Improvement
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> [HIVE-13354|https://issues.apache.org/jira/browse/HIVE-13354] introduced the
> ability to set some parameters for the compaction through table properties,
> like the mapper memory size or compaction thresholds. This could be useful
> for the query-based compaction as well, for example if the insert of the
> query-based compaction is failing, we would have a possibility to tune the
> compaction run directly. First it should be investigated which properties are
> possible and would make sense to set for the query base compaction. Then
> implement this feature for the query-based compaction.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
