[
https://issues.apache.org/jira/browse/HIVE-26443?focusedWorklogId=805228&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805228
]
ASF GitHub Bot logged work on HIVE-26443:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/22 13:40
Start Date: 31/Aug/22 13:40
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3513:
URL: https://github.com/apache/hive/pull/3513#discussion_r959600648
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -237,14 +244,18 @@ public void run() {
}
}
- private void scheduleCompactionIfRequired(CompactionInfo ci, Table t,
Partition p, String runAs, boolean metricsEnabled)
+ private void scheduleCompactionIfRequired(CompactionInfo ci, Database d,
Table t, Partition p, String runAs, boolean metricsEnabled)
throws MetaException {
StorageDescriptor sd = resolveStorageDescriptor(t, p);
try {
ValidWriteIdList validWriteIds = resolveValidWriteIds(t);
CompactionType type = checkForCompaction(ci, validWriteIds, sd,
t.getParameters(), runAs);
if (type != null) {
ci.type = type;
+ ci.poolName =
t.getParameters().get(Constants.HIVE_COMPACTOR_WORKER_POOL);
Review Comment:
could we extract this logic into a separate method, like getPoolName, and
pass it as param to scheduleCompactionIfRequired?
Issue Time Tracking
-------------------
Worklog Id: (was: 805228)
Time Spent: 10h (was: 9h 50m)
> Add priority queueing to compaction
> -----------------------------------
>
> Key: HIVE-26443
> URL: https://issues.apache.org/jira/browse/HIVE-26443
> Project: Hive
> Issue Type: New Feature
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Attachments: Pool based compaction queues.docx
>
> Time Spent: 10h
> Remaining Estimate: 0h
>
> The details can be found in the attached design doc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
