[
https://issues.apache.org/jira/browse/HIVE-26498?focusedWorklogId=807247&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807247
]
ASF GitHub Bot logged work on HIVE-26498:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/22 03:01
Start Date: 09/Sep/22 03:01
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #3552:
URL: https://github.com/apache/hive/pull/3552#discussion_r966581077
##########
storage-api/src/java/org/apache/hadoop/hive/common/MaterializationSnapshot.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.common;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import java.io.IOException;
+import java.io.StringWriter;
+import java.io.UncheckedIOException;
+import java.io.Writer;
+import java.util.Map;
+
+/**
+ * Class to store snapshot data of Materialized view source tables.
+ * The data represents the state of the source tables when the view was
created/last rebuilt.
+ */
+public class MaterializationSnapshot {
+
+ public static MaterializationSnapshot fromJson(String jsonString) {
+ try {
+ return new ObjectMapper().readValue(jsonString,
MaterializationSnapshot.class);
+ } catch (JsonProcessingException e) {
+ // this is not a jsonString, fall back to treating it as
ValidTxnWriteIdList
+ return new MaterializationSnapshot(jsonString);
+ }
+ }
+
+ // Snapshot of native ACID tables.
+ private String validTxnList;
+ // Snapshot of non-native ACID and insert-only transactional tables. Key is
the fully qualified name of the table.
+ // Value is the unique id of the snapshot provided by the table's storage
HiveStorageHandler.
+ private Map<String, String> tableSnapshots;
+
+ private MaterializationSnapshot() {
+ }
+
+ public MaterializationSnapshot(String validTxnList) {
+ this.validTxnList = validTxnList;
+ this.tableSnapshots = null;
+ }
+
+ public MaterializationSnapshot(Map<String, String> tableSnapshots) {
+ this.validTxnList = null;
+ this.tableSnapshots = tableSnapshots;
+ }
+
+ /**
+ * Returns the json representation of this object.
+ * @return {@link String} containing a json.
+ */
+ public String asJsonString() {
+ try (Writer out = new StringWriter()) {
+ new ObjectMapper().writeValue(out, this);
+ return out.toString();
+ } catch (IOException e) {
+ throw new UncheckedIOException("Unable to convert " + this + " to json",
e);
+ }
+ }
+
+ @Override
+ public String toString() {
+ return "MaterializationSnapshot{" +
+ "validTxnList='" + validTxnList + '\'' +
+ ", tableSnapshots=" + tableSnapshots +
+ '}';
+ }
+
+ public String getValidTxnList() {
Review Comment:
added
##########
storage-api/src/java/org/apache/hadoop/hive/common/MaterializationSnapshot.java:
##########
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.common;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+
+import java.io.IOException;
+import java.io.StringWriter;
+import java.io.UncheckedIOException;
+import java.io.Writer;
+import java.util.Map;
+
+/**
+ * Class to store snapshot data of Materialized view source tables.
+ * The data represents the state of the source tables when the view was
created/last rebuilt.
+ */
+public class MaterializationSnapshot {
+
+ public static MaterializationSnapshot fromJson(String jsonString) {
+ try {
+ return new ObjectMapper().readValue(jsonString,
MaterializationSnapshot.class);
+ } catch (JsonProcessingException e) {
+ // this is not a jsonString, fall back to treating it as
ValidTxnWriteIdList
+ return new MaterializationSnapshot(jsonString);
+ }
+ }
+
+ // Snapshot of native ACID tables.
+ private String validTxnList;
+ // Snapshot of non-native ACID and insert-only transactional tables. Key is
the fully qualified name of the table.
+ // Value is the unique id of the snapshot provided by the table's storage
HiveStorageHandler.
+ private Map<String, String> tableSnapshots;
+
+ private MaterializationSnapshot() {
+ }
+
+ public MaterializationSnapshot(String validTxnList) {
+ this.validTxnList = validTxnList;
+ this.tableSnapshots = null;
+ }
+
+ public MaterializationSnapshot(Map<String, String> tableSnapshots) {
+ this.validTxnList = null;
+ this.tableSnapshots = tableSnapshots;
+ }
+
+ /**
+ * Returns the json representation of this object.
+ * @return {@link String} containing a json.
+ */
+ public String asJsonString() {
+ try (Writer out = new StringWriter()) {
+ new ObjectMapper().writeValue(out, this);
+ return out.toString();
+ } catch (IOException e) {
+ throw new UncheckedIOException("Unable to convert " + this + " to json",
e);
+ }
+ }
+
+ @Override
+ public String toString() {
+ return "MaterializationSnapshot{" +
+ "validTxnList='" + validTxnList + '\'' +
+ ", tableSnapshots=" + tableSnapshots +
+ '}';
+ }
+
+ public String getValidTxnList() {
+ return validTxnList;
+ }
+
+ public Map<String, String> getTableSnapshots() {
Review Comment:
added
Issue Time Tracking
-------------------
Worklog Id: (was: 807247)
Time Spent: 4h 10m (was: 4h)
> Implement MV maintenance with Iceberg sources using full rebuild
> ----------------------------------------------------------------
>
> Key: HIVE-26498
> URL: https://issues.apache.org/jira/browse/HIVE-26498
> Project: Hive
> Issue Type: Sub-task
> Components: Materialized views
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> {code}
> set hive.support.concurrency=true;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> create external table tbl_ice(a int, b string, c int) stored by iceberg
> stored as orc tblproperties ('format-version'='2');
> insert into tbl_ice values (1, 'one', 50), (2, 'two', 51), (3, 'three', 52),
> (4, 'four', 53), (5, 'five', 54);
> create materialized view mat1 as
> select b, c from tbl_ice where c > 52;
> insert into tbl_ice values (111, 'one', 55), (333, 'two', 56);
> explain cbo
> alter materialized view mat1 rebuild;
> alter materialized view mat1 rebuild;
> {code}
> MV full rebuild plan
> {code}
> CBO PLAN:
> HiveProject(b=[$1], c=[$2])
> HiveFilter(condition=[>($2, 52)])
> HiveTableScan(table=[[default, tbl_ice]], table:alias=[tbl_ice])
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
