[
https://issues.apache.org/jira/browse/HIVE-26471?focusedWorklogId=809540&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-809540
]
ASF GitHub Bot logged work on HIVE-26471:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/22 14:04
Start Date: 16/Sep/22 14:04
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #3521:
URL: https://github.com/apache/hive/pull/3521#discussion_r973062171
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/CompactionMetricData.java:
##########
@@ -148,6 +152,10 @@ Map<String, Long> getStateCount() {
return new HashMap<>(stateCount);
}
+ public Map<String, Integer> getPoolCount() {
+ return new HashMap<>(poolCount);
Review Comment:
I think it is enough if only `CompactionMetricData` is immutable. The
returned shallow copy allows the caller to modify these collections without
modifying CompactionMetricData itself, which is fine in my opinion. However, in
the current case both methods are used only one time making this discussion
rather theoretical. I simply copied the way the already existing method works.
Issue Time Tracking
-------------------
Worklog Id: (was: 809540)
Time Spent: 2h 20m (was: 2h 10m)
> New metric for Compaction pooling
> ---------------------------------
>
> Key: HIVE-26471
> URL: https://issues.apache.org/jira/browse/HIVE-26471
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> To be able to properly supervise the pool based compaction, a new metric is
> required:
> Number of 'Initiated' compaction requests per compaction pool.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
