[
https://issues.apache.org/jira/browse/HIVE-26564?focusedWorklogId=812312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-812312
]
ASF GitHub Bot logged work on HIVE-26564:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/22 02:15
Start Date: 27/Sep/22 02:15
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on code in PR #3621:
URL: https://github.com/apache/hive/pull/3621#discussion_r980666461
##########
service/src/test/org/apache/hive/service/cli/operation/TestOperationLogManager.java:
##########
@@ -61,6 +60,7 @@ public void setUp() throws Exception {
HiveConf.setIntVar(hiveConf,
HiveConf.ConfVars.HIVE_SERVER2_WEBUI_MAX_HISTORIC_QUERIES, 1);
HiveConf.setIntVar(hiveConf, HiveConf.ConfVars.HIVE_SERVER2_WEBUI_PORT,
8080);
HiveConf.setBoolVar(hiveConf, HiveConf.ConfVars.HIVE_IN_TEST, true);
+ HiveConf.setBoolVar(hiveConf, HiveConf.ConfVars.HIVE_TESTING_REMOVE_LOGS,
false);
Review Comment:
why this property should set to false when
HIVE_SERVER2_HISTORIC_OPERATION_LOG_ENABLED is enabled? we do not want to set
this in production.
Issue Time Tracking
-------------------
Worklog Id: (was: 812312)
Time Spent: 0.5h (was: 20m)
> Separate query live operation log and historical operation log
> --------------------------------------------------------------
>
> Key: HIVE-26564
> URL: https://issues.apache.org/jira/browse/HIVE-26564
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Affects Versions: 4.0.0-alpha-2
> Reporter: Yi Zhang
> Assignee: Yi Zhang
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> HIVE-24802 added OperationLogManager to support historical operation logs.
> OperationLogManager.createOperationLog creates operation log inside
> historical operation log dir if
> HIVE_SERVER2_HISTORIC_OPERATION_LOG_ENABLED=true. This is confusing, since on
> session level, SessionManager and HiveSession are using original operation
> log session directory.
> Proposed change is to separate live query's operation log and historical
> operation log. Upon operation close, OperationLogManager.closeOperation is
> called to move the operation log from session directory to historical log
> dir. OperationLogManager is only responsible to clean up historical operation
> logs.
> This change also makes it easier to manage historical logs, for example, user
> may want to persist historical logs, it is easier to differentiate live and
> historical operation logs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
