[
https://issues.apache.org/jira/browse/HIVE-26437?focusedWorklogId=818680&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-818680
]
ASF GitHub Bot logged work on HIVE-26437:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/22 05:53
Start Date: 20/Oct/22 05:53
Worklog Time Spent: 10m
Work Description: pudidic commented on code in PR #3644:
URL: https://github.com/apache/hive/pull/3644#discussion_r1000168804
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -1254,6 +1273,7 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path
cmRoot, Hive hiveDb)
// Get the counter to store the snapshots created & deleted at
source.
replSnapshotCount = new SnapshotUtils.ReplSnapshotCount();
}
+ ExportService exportService = new ExportService(conf);
Review Comment:
Please move the ExportService object creation higher than a database level.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -1290,6 +1310,21 @@ Long bootStrapDump(Path dumpRoot, DumpMetaData dmd, Path
cmRoot, Hive hiveDb)
}
}
+ if (exportService != null && exportService.isExportServiceRunning())
{
Review Comment:
Please move the ExportService object creation higher than a database level.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -952,6 +954,7 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData
dmd, Path cmRoot, Hive
}
}
for(String matchedDbName : Utils.matchesDb(hiveDb,
work.dbNameOrPattern)) {
+ ExportService exportService = new ExportService(conf);
Review Comment:
Please move the ExportService object creation higher than a database level.
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java:
##########
@@ -978,6 +981,22 @@ private Long incrementalDump(Path dumpRoot, DumpMetaData
dmd, Path cmRoot, Hive
LOG.debug(te.getMessage());
}
}
+
+ if (exportService != null && exportService.isExportServiceRunning())
{
Review Comment:
Please move the ExportService object creation higher than a database level.
Issue Time Tracking
-------------------
Worklog Id: (was: 818680)
Time Spent: 1h 40m (was: 1.5h)
> dump unpartitioned Tables in parallel
> -------------------------------------
>
> Key: HIVE-26437
> URL: https://issues.apache.org/jira/browse/HIVE-26437
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: Amit Saonerkar
> Assignee: Amit Saonerkar
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
