[ https://issues.apache.org/jira/browse/HIVE-26243?focusedWorklogId=820527&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-820527 ]
ASF GitHub Bot logged work on HIVE-26243: ----------------------------------------- Author: ASF GitHub Bot Created on: 26/Oct/22 14:20 Start Date: 26/Oct/22 14:20 Worklog Time Spent: 10m Work Description: asolimando commented on code in PR #3317: URL: https://github.com/apache/hive/pull/3317#discussion_r1005748716 ########## ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java: ########## @@ -4461,17 +4464,21 @@ public static ImmutablePair<VectorAggregationDesc,String> getVectorAggregationDe VectorizationContext vContext) throws HiveException { - VectorizedUDAFs annotation = - AnnotationUtils.getAnnotation(evaluator.getClass(), VectorizedUDAFs.class); - if (annotation == null) { - String issue = - "Evaluator " + evaluator.getClass().getSimpleName() + " does not have a " + - "vectorized UDAF annotation (aggregation: \"" + aggregationName + "\"). " + - "Vectorization not supported"; - return new ImmutablePair<VectorAggregationDesc,String>(null, issue); + Class<? extends VectorAggregateExpression>[] vecAggrClasses; + if (aggregationName.equals("ds_kll_sketch")) { Review Comment: I have drafted a solution using a private enumeration, please let me know if I got what you meant Issue Time Tracking ------------------- Worklog Id: (was: 820527) Time Spent: 2h 10m (was: 2h) > Add vectorized implementation of the 'ds_kll_sketch' UDAF > --------------------------------------------------------- > > Key: HIVE-26243 > URL: https://issues.apache.org/jira/browse/HIVE-26243 > Project: Hive > Issue Type: Improvement > Components: UDF, Vectorization > Affects Versions: 4.0.0-alpha-2 > Reporter: Alessandro Solimando > Assignee: Alessandro Solimando > Priority: Major > Labels: pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > _ds_kll_sketch_ UDAF does not have a vectorized implementation at the moment, > the present ticket aims at bridging this gap. > This is particularly important because vectorization has an "all or nothing" > approach, so if this function is used at the side of vectorized functions, > they won't be able to benefit from vectorized execution. -- This message was sent by Atlassian Jira (v8.20.10#820010)