[ https://issues.apache.org/jira/browse/HIVE-25813?focusedWorklogId=821227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-821227 ]
ASF GitHub Bot logged work on HIVE-25813: ----------------------------------------- Author: ASF GitHub Bot Created on: 28/Oct/22 01:18 Start Date: 28/Oct/22 01:18 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on code in PR #3627: URL: https://github.com/apache/hive/pull/3627#discussion_r1007505842 ########## hbase-handler/src/test/results/positive/hbase_queries.q.out: ########## @@ -987,15 +992,17 @@ CREATE EXTERNAL TABLE `hbase_table_1_like`( `key` int COMMENT 'It is a column key', `value` string COMMENT 'It is the column string value') ROW FORMAT SERDE - 'org.apache.hadoop.hive.hbase.HBaseSerDe' -STORED BY - 'org.apache.hadoop.hive.hbase.HBaseStorageHandler' + 'org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe' WITH SERDEPROPERTIES ( - 'hbase.columns.mapping'='cf:string', - 'serialization.format'='1') + 'hbase.columns.mapping'='cf:string') Review Comment: nit: do we need this serde properties after this? Issue Time Tracking ------------------- Worklog Id: (was: 821227) Time Spent: 2h 50m (was: 2h 40m) > CREATE TABLE x LIKE storagehandler-based-source fails > ------------------------------------------------------ > > Key: HIVE-25813 > URL: https://issues.apache.org/jira/browse/HIVE-25813 > Project: Hive > Issue Type: Bug > Reporter: Sai Hemanth Gantasala > Assignee: Sai Hemanth Gantasala > Priority: Major > Labels: pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > > {code:java} > CREATE EXTERNAL TABLE default.dbs ( > DB_ID bigint, > DB_LOCATION_URI string, > NAME string, > OWNER_NAME string, > OWNER_TYPE string ) > STORED BY 'org.apache.hive.storage.jdbc.JdbcStorageHandler' > TBLPROPERTIES ( > 'hive.sql.database.type' = 'MYSQL', > 'hive.sql.jdbc.driver' = 'com.mysql.jdbc.Driver', > 'hive.sql.jdbc.url' = 'jdbc:mysql://localhost:3306/hive1', > 'hive.sql.dbcp.username' = 'hive1', > 'hive.sql.dbcp.password' = 'cloudera', > 'hive.sql.query' = 'SELECT DB_ID, DB_LOCATION_URI, NAME, OWNER_NAME, > OWNER_TYPE FROM DBS' > ); > CREATE TABLE default.dbscopy LIKE default.dbs; > Caused by: java.lang.NullPointerException > at > org.apache.hadoop.hive.metastore.HiveMetaStoreUtils.getFieldsFromDeserializer(HiveMetaStoreUtils.java:186) > {code} > With this patch, we don't want to copy over the table properties or any other > physical properties (storage handler e.t.c) of the source table when CREATE > TABLE LIKE TABLE command is executed. Only table schema (logical properties) > should be copied. This implementation is consistent with other SQL engines > like Mysql, Redshift etc. -- This message was sent by Atlassian Jira (v8.20.10#820010)