[ https://issues.apache.org/jira/browse/HIVE-26580?focusedWorklogId=824697&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-824697 ]
ASF GitHub Bot logged work on HIVE-26580: ----------------------------------------- Author: ASF GitHub Bot Created on: 09/Nov/22 17:30 Start Date: 09/Nov/22 17:30 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3708: URL: https://github.com/apache/hive/pull/3708#discussion_r1018203932 ########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ########## @@ -4013,6 +4018,11 @@ private String getShowCompactFilterClause(ShowCompactRequest request) { " WHERE " + StringUtils.join(" AND ", params) : EMPTY; } + private String getShowCompactSortingOrderClause(ShowCompactRequest request) { + String sortingOrder = request.getOrder(); + return isNotBlank(sortingOrder) ? String.join("\t"," ORDER BY ",sortingOrder) : TxnQueries.SHOW_COMPACTION_ORDERBY_CLAUSE; Review Comment: reformat, spaces are missing also, what is String. join is doing here? can we simply "ORDER BY "+sortingOrder Issue Time Tracking ------------------- Worklog Id: (was: 824697) Time Spent: 5h 40m (was: 5.5h) > SHOW COMPACTIONS should support ordering and limiting functionality in > filtering options > ---------------------------------------------------------------------------------------- > > Key: HIVE-26580 > URL: https://issues.apache.org/jira/browse/HIVE-26580 > Project: Hive > Issue Type: Improvement > Affects Versions: 3.0.0 > Reporter: KIRTI RUGE > Assignee: KIRTI RUGE > Priority: Major > Labels: pull-request-available > Time Spent: 5h 40m > Remaining Estimate: 0h > > SHOW COMPACTION should provide ordering by defied table . It should also > support limitation of fetched records -- This message was sent by Atlassian Jira (v8.20.10#820010)