[ 
https://issues.apache.org/jira/browse/HIVE-26243?focusedWorklogId=825428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-825428
 ]

ASF GitHub Bot logged work on HIVE-26243:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Nov/22 18:51
            Start Date: 11/Nov/22 18:51
    Worklog Time Spent: 10m 
      Work Description: asolimando commented on code in PR #3317:
URL: https://github.com/apache/hive/pull/3317#discussion_r1020482885


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java:
##########
@@ -244,7 +247,7 @@
 
 public class Vectorizer implements PhysicalPlanResolver {
 
-  protected static transient final Logger LOG = 
LoggerFactory.getLogger(Vectorizer.class);
+  protected static final Logger LOG = 
LoggerFactory.getLogger(Vectorizer.class);

Review Comment:
   Sonar marked it as [code 
smell](https://sonarcloud.io/project/issues?issues=AYJpdDZw9k-CsauE5Bp5&open=AYJpdDZw9k-CsauE5Bp5&id=apache_hive)
 because for non-`Serializable` classes the modifier is a no-op and it's 
suggested to remove it.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 825428)
    Time Spent: 4h 40m  (was: 4.5h)

> Add vectorized implementation of the 'ds_kll_sketch' UDAF
> ---------------------------------------------------------
>
>                 Key: HIVE-26243
>                 URL: https://issues.apache.org/jira/browse/HIVE-26243
>             Project: Hive
>          Issue Type: Improvement
>          Components: UDF, Vectorization
>    Affects Versions: 4.0.0-alpha-2
>            Reporter: Alessandro Solimando
>            Assignee: Alessandro Solimando
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> _ds_kll_sketch_ UDAF does not have a vectorized implementation at the moment, 
> the present ticket aims at bridging this gap.
> This is particularly important because vectorization has an "all or nothing" 
> approach, so if this function is used at the side of vectorized functions, 
> they won't be able to benefit from vectorized execution.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to