[
https://issues.apache.org/jira/browse/HIVE-26726?focusedWorklogId=826898&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-826898
]
ASF GitHub Bot logged work on HIVE-26726:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/22 16:02
Start Date: 17/Nov/22 16:02
Worklog Time Spent: 10m
Work Description: scarlin-cloudera commented on code in PR #3752:
URL: https://github.com/apache/hive/pull/3752#discussion_r1025388984
##########
ql/src/test/queries/clientpositive/windowing_tinyint.q:
##########
@@ -0,0 +1,11 @@
+--! qt:dataset:src
Review Comment:
Done
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/ValueBoundaryScanner.java:
##########
@@ -760,6 +760,7 @@ public static SingleValueBoundaryScanner
getBoundaryScanner(BoundaryDef start, B
case "int":
case "bigint":
case "smallint":
+ case "tinyint":
Review Comment:
I just tested for the code at line 730. That one uses a PrimitiveCategory
and the "BYTE" case covers the tinyint. I looked around and I think this is
the only place that needs changing.
Issue Time Tracking
-------------------
Worklog Id: (was: 826898)
Time Spent: 50m (was: 40m)
> tinyint column with windowing fn crashes at runtime
> ---------------------------------------------------
>
> Key: HIVE-26726
> URL: https://issues.apache.org/jira/browse/HIVE-26726
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Reporter: Steve Carlin
> Assignee: Steve Carlin
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
>
> Using a tinyint column in a windowing function is causing a runtime exception.
> The following SQL
>
> {code:java}
> CREATE TABLE t_test(
> int_col int,
> tinyint_col tinyint
> );
> insert into t_test values (1, 1);
> select
> count(int_col) over (order by tinyint_col)
> from t_test;
> {code}
>
> produces this error:
> {code:java}
> Caused by: org.apache.hadoop.hive.ql.metadata.HiveException: Internal Error:
> attempt to setup a Window for typeString: 'tinyint'
> at
> org.apache.hadoop.hive.ql.udf.ptf.SingleValueBoundaryScanner.getBoundaryScanner(ValueBoundaryScanner.java:783)
> at
> org.apache.hadoop.hive.ql.udf.ptf.SingleValueBoundaryScanner.getScanner(ValueBoundaryScanner.java:719)
> at
> org.apache.hadoop.hive.ql.udf.ptf.ValueBoundaryScanner.getScanner(ValueBoundaryScanner.java:332)
> at
> org.apache.hadoop.hive.ql.udf.ptf.PTFRangeUtil.getRange(PTFRangeUtil.java:40)
> at
> org.apache.hadoop.hive.ql.exec.vector.ptf.VectorPTFGroupBatches.finishPartition(VectorPTFGroupBatches.java:442)
> at
> org.apache.hadoop.hive.ql.exec.vector.ptf.VectorPTFOperator.finishPartition(VectorPTFOperator.java:632)
> at
> org.apache.hadoop.hive.ql.exec.vector.ptf.VectorPTFOperator.closeOp(VectorPTFOperator.java:783){code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
