[
https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=827084&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-827084
]
ASF GitHub Bot logged work on HIVE-26716:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Nov/22 08:55
Start Date: 18/Nov/22 08:55
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1026168632
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java:
##########
@@ -1823,6 +1831,22 @@ private int getBucketProperty(Object row) {
}
}
+ /**
+ * Reuired for rebalancing compaction. Encodes the raw bucket property set
by the compactor
+ * @param row The acid row in which the bucket needs to be updated.
+ */
+ private void setBucketProperty(Configuration hiveConf, Object row, int
bucketId) {
+ //TODO: statementId?
+ BucketCodec codec = conf.getBucketingVersion() == 2 ? BucketCodec.V1 :
BucketCodec.V0;
Review Comment:
haven't seen in a code BucketCodec.V0 being used for acid, do we need this?
````
BucketCodec.V1.encode(new
AcidOutputFormat.Options(hiveConf).bucket(bucketId))
````
Issue Time Tracking
-------------------
Worklog Id: (was: 827084)
Time Spent: 3h (was: 2h 50m)
> Query based Rebalance compaction on full acid tables
> ----------------------------------------------------
>
> Key: HIVE-26716
> URL: https://issues.apache.org/jira/browse/HIVE-26716
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: ACID, compaction, pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Support rebalancing compaction on fully ACID tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
