[ https://issues.apache.org/jira/browse/HIVE-26701?focusedWorklogId=827320&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-827320 ]
ASF GitHub Bot logged work on HIVE-26701: ----------------------------------------- Author: ASF GitHub Bot Created on: 19/Nov/22 03:19 Start Date: 19/Nov/22 03:19 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on code in PR #3773: URL: https://github.com/apache/hive/pull/3773#discussion_r1027024809 ########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java: ########## @@ -369,11 +369,15 @@ public void setConf(Configuration conf){ int maxPoolSize = MetastoreConf.getIntVar(conf, ConfVars.CONNECTION_POOLING_MAX_CONNECTIONS); synchronized (TxnHandler.class) { - if (connPool == null) { - connPool = setupJdbcConnectionPool(conf, maxPoolSize); - } - if (connPoolMutex == null) { - connPoolMutex = setupJdbcConnectionPool(conf, maxPoolSize); + try (DataSourceProvider.DataSourceNameConfigurator configurator = + new DataSourceProvider.DataSourceNameConfigurator(conf, "txn")) { Review Comment: sure Issue Time Tracking ------------------- Worklog Id: (was: 827320) Time Spent: 50m (was: 40m) > Enable metrics for Database connection pools(1 & 2) used by ObjectStore in HMS > ------------------------------------------------------------------------------ > > Key: HIVE-26701 > URL: https://issues.apache.org/jira/browse/HIVE-26701 > Project: Hive > Issue Type: Bug > Components: Standalone Metastore > Reporter: Taraka Rama Rao Lethavadla > Assignee: Zhihua Deng > Priority: Major > Labels: hive-4.0.0-must, pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > We have metrics enabled for database connection pools(3 & 4) used in > TxnHandler. We don't have the same for pools(1 & 2) used by ObjectStore -- This message was sent by Atlassian Jira (v8.20.10#820010)