[ https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=828879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828879 ]
ASF GitHub Bot logged work on HIVE-26716: ----------------------------------------- Author: ASF GitHub Bot Created on: 25/Nov/22 10:19 Start Date: 25/Nov/22 10:19 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3746: URL: https://github.com/apache/hive/pull/3746#discussion_r1032243190 ########## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java: ########## @@ -203,19 +214,23 @@ CompactionQueryBuilder setIsDeleteDelta(boolean deleteDelta) { * @param resultTableName the name of the table we are running the operation on * @throws IllegalArgumentException if compactionType is null */ - CompactionQueryBuilder(CompactionType compactionType, Operation operation, + CompactionQueryBuilder(CompactionType compactionType, Operation operation, boolean crud, String resultTableName) { if (compactionType == null) { throw new IllegalArgumentException("CompactionQueryBuilder.CompactionType cannot be null"); } + this.compactionType = compactionType; this.operation = operation; this.resultTableName = resultTableName; - major = compactionType == CompactionType.MAJOR_CRUD - || compactionType == CompactionType.MAJOR_INSERT_ONLY; - crud = - compactionType == CompactionType.MAJOR_CRUD || compactionType == CompactionType.MINOR_CRUD; - minor = !major; + this.crud = crud; insertOnly = !crud; + major = CompactionType.MAJOR.equals(compactionType); Review Comment: what's the purpose of these local vars (i.e. minor, major, rebalance), why don't you use the compactionType? Issue Time Tracking ------------------- Worklog Id: (was: 828879) Time Spent: 6h (was: 5h 50m) > Query based Rebalance compaction on full acid tables > ---------------------------------------------------- > > Key: HIVE-26716 > URL: https://issues.apache.org/jira/browse/HIVE-26716 > Project: Hive > Issue Type: Sub-task > Components: Hive > Reporter: László Végh > Assignee: László Végh > Priority: Major > Labels: ACID, compaction, pull-request-available > Time Spent: 6h > Remaining Estimate: 0h > > Support rebalancing compaction on fully ACID tables. -- This message was sent by Atlassian Jira (v8.20.10#820010)