[ https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=828935&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828935 ]
ASF GitHub Bot logged work on HIVE-26716: ----------------------------------------- Author: ASF GitHub Bot Created on: 25/Nov/22 12:54 Start Date: 25/Nov/22 12:54 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3746: URL: https://github.com/apache/hive/pull/3746#discussion_r1032428970 ########## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java: ########## @@ -402,20 +416,14 @@ protected Boolean findNextCompactionAndExecute(boolean collectGenericStats, bool todo Find a more generic approach to collecting files in the same logical bucket to compact within the same task (currently we're using Tez split grouping). */ - QueryCompactor queryCompactor = QueryCompactorFactory.getQueryCompactor(t, conf, ci); - computeStats = (queryCompactor == null && collectMrStats) || collectGenericStats; + Compactor compactor = compactorFactory.getQueryCompactor(msc, t, conf, ci); Review Comment: should we rename `getQueryCompactor` -> `get/createCompactor()`? Issue Time Tracking ------------------- Worklog Id: (was: 828935) Time Spent: 9h 20m (was: 9h 10m) > Query based Rebalance compaction on full acid tables > ---------------------------------------------------- > > Key: HIVE-26716 > URL: https://issues.apache.org/jira/browse/HIVE-26716 > Project: Hive > Issue Type: Sub-task > Components: Hive > Reporter: László Végh > Assignee: László Végh > Priority: Major > Labels: ACID, compaction, pull-request-available > Time Spent: 9h 20m > Remaining Estimate: 0h > > Support rebalancing compaction on fully ACID tables. -- This message was sent by Atlassian Jira (v8.20.10#820010)