[ https://issues.apache.org/jira/browse/HIVE-26537?focusedWorklogId=830437&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-830437 ]
ASF GitHub Bot logged work on HIVE-26537: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Dec/22 19:21 Start Date: 01/Dec/22 19:21 Worklog Time Spent: 10m Work Description: saihemanth-cloudera commented on code in PR #3599: URL: https://github.com/apache/hive/pull/3599#discussion_r1037482722 ########## standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java: ########## @@ -1274,7 +1308,46 @@ public void createDatabase(Database db) if (!db.isSetCatalogName()) { db.setCatalogName(getDefaultCatalog(conf)); } - client.create_database(db); + CreateDatabaseRequest req = new CreateDatabaseRequest(); + req.setDatabaseName(db.getName()); + if (db.isSetDescription()) { + req.setDescription(db.getDescription()); + } + if (db.isSetLocationUri()) { + req.setLocationUri(db.getLocationUri()); + } + if (db.isSetParameters()) { + req.setParameters(db.getParameters()); + } + if (db.isSetPrivileges()) { + req.setPrivileges(db.getPrivileges()); + } + if (db.isSetOwnerName()) { + req.setOwnerName(db.getOwnerName()); + } + if (db.isSetOwnerType()) { Review Comment: Thrift objects don't come with Builder methods. So I don't think there is a way to implement your suggestion here. Issue Time Tracking ------------------- Worklog Id: (was: 830437) Time Spent: 4h 10m (was: 4h) > Deprecate older APIs in the HMS > ------------------------------- > > Key: HIVE-26537 > URL: https://issues.apache.org/jira/browse/HIVE-26537 > Project: Hive > Issue Type: Improvement > Affects Versions: 4.0.0-alpha-1, 4.0.0-alpha-2 > Reporter: Sai Hemanth Gantasala > Assignee: Sai Hemanth Gantasala > Priority: Major > Labels: pull-request-available > Time Spent: 4h 10m > Remaining Estimate: 0h > > This Jira is to track the clean-up(deprecate older APIs and point the HMS > client to the newer APIs) work in the hive metastore server. > More details will be added here soon. -- This message was sent by Atlassian Jira (v8.20.10#820010)