[
https://issues.apache.org/jira/browse/HIVE-26847?focusedWorklogId=834114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-834114
]
ASF GitHub Bot logged work on HIVE-26847:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/22 10:16
Start Date: 16/Dec/22 10:16
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3856:
URL: https://github.com/apache/hive/pull/3856#discussion_r1050565708
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1127,6 +1127,8 @@ public enum ConfVars {
"command should handle partition retention. If enabled, and if a
specific partition's age exceeded\n" +
"retention period the partition will be dropped along with data"),
+ MATERIALIZED_VIEW_ENABLED("metastore.materialized.view.enabled",
"metastore.materialized.view.enabled", true,
Review Comment:
if there is a lack of auditing for MV, use regular tables. Note, permissions
are checked in HS2 at compile time just like for regular tables. Maybe it would
be better to restrict MV creation via the Ranger rules? cc @saihemanth-cloudera
or maybe this check should be somewhere in:
````
if (!ss.isAuthorizationModeV2()) {
CommandAuthorizerV1.doAuthorization(op, sem, ss, inputs, outputs);
--> authorizeOperation(op, sem, inputs, outputs, db, authorizer);
} else {
CommandAuthorizerV2.doAuthorization(op, sem, ss, inputs, outputs,
command);
--> ss.getAuthorizerV2().checkPrivileges(hiveOpType,
inputsHObjs, outputHObjs, authzContextBuilder.build());
}
````
Issue Time Tracking
-------------------
Worklog Id: (was: 834114)
Time Spent: 2h 50m (was: 2h 40m)
> Allow a config to disable creation of Materialized Views
> --------------------------------------------------------
>
> Key: HIVE-26847
> URL: https://issues.apache.org/jira/browse/HIVE-26847
> Project: Hive
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
