[ https://issues.apache.org/jira/browse/HIVE-26802?focusedWorklogId=836580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836580 ]
ASF GitHub Bot logged work on HIVE-26802: ----------------------------------------- Author: ASF GitHub Bot Created on: 03/Jan/23 10:22 Start Date: 03/Jan/23 10:22 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3882: URL: https://github.com/apache/hive/pull/3882#discussion_r1060447398 ########## itests/qtest/src/test/java/org/apache/hadoop/hive/cli/TestMiniLlapLocalCompactorCliDriver.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.cli; + +import org.apache.hadoop.hive.cli.control.CliAdapter; +import org.apache.hadoop.hive.cli.control.CliConfigs; +import org.apache.hadoop.hive.cli.control.SplitSupport; +import org.apache.hadoop.hive.ql.session.SessionState; +import org.apache.hadoop.hive.ql.txn.compactor.Worker; +import org.junit.AfterClass; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TestRule; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; +import org.junit.runners.Parameterized.Parameters; + +import java.io.File; +import java.util.List; +import java.util.concurrent.atomic.AtomicBoolean; + +@RunWith(Parameterized.class) +public class TestMiniLlapLocalCompactorCliDriver { + + static CliAdapter adapter = new CliConfigs.MiniLlapLocalCompactorCliConfig().getCliAdapter(); + + private static int N_SPLITS = 32; + + private static final AtomicBoolean stop = new AtomicBoolean(); + private static Worker worker; + @Parameters(name = "{0}") + public static List<Object[]> getParameters() throws Exception { + return SplitSupport.process(adapter.getParameters(), TestMiniLlapLocalCompactorCliDriver.class, N_SPLITS); + } + + @ClassRule + public static TestRule cliClassRule = adapter.buildClassRule(); + + @Rule + public TestRule cliTestRule = adapter.buildTestRule(); + + @BeforeClass + public static void setup() throws Exception { + worker = new Worker(); Review Comment: why just worker? also can't we reuse the helper method: ```` TxnCommandsBaseForTests.runWorker(SessionState.get().getConf()); ```` Issue Time Tracking ------------------- Worklog Id: (was: 836580) Time Spent: 1h 10m (was: 1h) > Create qtest running QB compaction queries > ------------------------------------------ > > Key: HIVE-26802 > URL: https://issues.apache.org/jira/browse/HIVE-26802 > Project: Hive > Issue Type: Improvement > Reporter: Zoltán Rátkai > Assignee: Zoltán Rátkai > Priority: Minor > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Create a qtest that runs the queries that query-based compaction runs. > Not so much to check for correct data but more to check the query plans, to > simplify tracing changes in compilation that might affect QB compaction. -- This message was sent by Atlassian Jira (v8.20.10#820010)