[
https://issues.apache.org/jira/browse/HIVE-26903?focusedWorklogId=837253&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837253
]
ASF GitHub Bot logged work on HIVE-26903:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jan/23 15:01
Start Date: 05/Jan/23 15:01
Worklog Time Spent: 10m
Work Description: veghlaci05 opened a new pull request, #3916:
URL: https://github.com/apache/hive/pull/3916
### What changes were proposed in this pull request?
Compactor threads are no longer daemon threads allowing them to shutdown
gracefully, and close/cleanup all related resources
### Why are the changes needed?
Daemon threads are terminated abruptly without executing the code in
catch/finally blocks. As a result compactor threads may leave the metastore in
an inconsistent state.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manually and through unit tests
Issue Time Tracking
-------------------
Worklog Id: (was: 837253)
Remaining Estimate: 0h
Time Spent: 10m
> Compactor threads should gracefully shutdown
> --------------------------------------------
>
> Key: HIVE-26903
> URL: https://issues.apache.org/jira/browse/HIVE-26903
> Project: Hive
> Issue Type: Improvement
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently the compactor threads are daemon threads, which means the JVM will
> not wait for these threads to finish. (see:
> [https://github.com/apache/hive/blob/431e7d9e5431a808106d8db81e11aea74f040da5/ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorThread.java#L81)]
> As a result during system shutdown, JVM may close all daemon threads
> abruptly (JVM won't wait for a thread to sleep/wait, and no
> InterruptedException is thrown), so the threads don't have any chance to
> shutdown gracefully. This can lead to inconsistent/corrupted state in the
> Metastore or on the File system.
> Make the compactor threads user threads, and handle shutdown accordingly.
> Make sure interrupts and InterruptedException is handled accordingly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
