[
https://issues.apache.org/jira/browse/HIVE-26910?focusedWorklogId=837334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837334
]
ASF GitHub Bot logged work on HIVE-26910:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jan/23 21:43
Start Date: 05/Jan/23 21:43
Worklog Time Spent: 10m
Work Description: cnauroth opened a new pull request, #3918:
URL: https://github.com/apache/hive/pull/3918
### What changes were proposed in this pull request?
`TestHS2ImpersonationWithRemoteMS` fails on branch-3. It makes assertions
about the state of the warehouse directory, but it doesn't account for a part
of metastore initialization that updates the warehouse directory to
parameterize it by port number for test isolation.
`MetaStoreTestUtils#startMetaStoreWithRetry` sets the warehouse directory as
the new `metastore.warehouse.dir` property.
`AbstractHiveService#get/setWareHouseDir` later works with the deprecated
`hive.metastore.warehouse.dir` property. `MetastoreConf` will take care of
resolving requests for the new property to values under the old property, but
not vice versa.
On master, [HIVE-19104](https://issues.apache.org/jira/browse/HIVE-19104)
included an additional line in `MiniHs2` to make sure these 2 properties would
stay in sync for test runs. This is a slightly modified backport of that patch
to branch-3.
There is only one significant difference compared to the master patch. I
needed to resolve a merge conflict in `WarehouseInstance`. This code is
different on branch-3, because it clones a copy of the `HiveConf` before
starting the metastore. (On master, it doesn't make a clone.) I traced this
difference to [HIVE-19812](https://issues.apache.org/jira/browse/HIVE-19812),
in which slightly different patches were committed to master and branch-3:
* master: 9bc90f28cf4406d74f9597837c2b72c809b582e6
* branch-3: 369798d90367187714ba68ff55784cff1342b020
Only the branch-3 patch had a `WarehouseInstance` change. I reviewed
comments on HIVE-19812 / #365, but I couldn't find any record of why branch-3
needed this change. I have decided to preserve the behavior of cloning a copy.
### Why are the changes needed?
This patch is required as part of getting a clean CI run on branch-3 in
preparation for a 3.2.0 release.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Without this patch, `TestHS2ImpersonationWithRemoteMS`fails locally. After
applying the patch, the test passes. I also confirmed successful runs of all
other test suites altered in this patch.
Issue Time Tracking
-------------------
Worklog Id: (was: 837334)
Remaining Estimate: 0h
Time Spent: 10m
> Backport HIVE-19104: Use independent warehouse directories in test metastores.
> ------------------------------------------------------------------------------
>
> Key: HIVE-26910
> URL: https://issues.apache.org/jira/browse/HIVE-26910
> Project: Hive
> Issue Type: Sub-task
> Components: Test
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Major
> Labels: hive-3.2.0-must
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{TestHS2ImpersonationWithRemoteMS}} fails on branch-3. It makes assertions
> about the state of the warehouse directory, but it doesn't account for a part
> of metastore initialization that updates the warehouse directory to
> parameterize it by port number for test isolation.
> {{MetaStoreTestUtils#startMetaStoreWithRetry}} sets the warehouse directory
> as the new {{metastore.warehouse.dir}} property.
> {{AbstractHiveService#get/setWareHouseDir}} later works with the deprecated
> {{hive.metastore.warehouse.dir}} property. {{MetastoreConf}} will take care
> of resolving requests for the new property to values under the old property,
> but not vice versa.
> On master, HIVE-19104 included an additional line in {{MiniHs2}} to make sure
> these 2 properties would stay in sync for test runs. This issue tracks a
> slightly modified backport of that patch to branch-3.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
