[ 
https://issues.apache.org/jira/browse/HIVE-26908?focusedWorklogId=838609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838609
 ]

ASF GitHub Bot logged work on HIVE-26908:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Jan/23 12:16
            Start Date: 11/Jan/23 12:16
    Worklog Time Spent: 10m 
      Work Description: veghlaci05 commented on PR #3915:
URL: https://github.com/apache/hive/pull/3915#issuecomment-1378663402

   @tarak271 The change looks OK, my only concern here that with the 
introduction of the new config value, cleaner will stop working on existing 
clusters after the upgrade which can lead to ready for cleaning queue 
accumulation and performance issues, and finally escalations. For backward 
compatibility I would suggest to set an empty/null default value for the new 
config, and if it's not explicitly set, enable/disable cleaner according to the 
value in metastore.compactor.initiator.on. This also should be reflected in the 
description. @tarak271 , @deniskuzZ what do you think?




Issue Time Tracking
-------------------

    Worklog Id:     (was: 838609)
    Time Spent: 1h 20m  (was: 1h 10m)

> Disable Initiator on HMS instance at the same time enable Cleaner thread
> ------------------------------------------------------------------------
>
>                 Key: HIVE-26908
>                 URL: https://issues.apache.org/jira/browse/HIVE-26908
>             Project: Hive
>          Issue Type: New Feature
>          Components: Standalone Metastore
>            Reporter: Taraka Rama Rao Lethavadla
>            Assignee: Taraka Rama Rao Lethavadla
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> In the current implementation, both Initiator and Cleaner are either enabled 
> or disabled using the same configĀ 
> {noformat}
> hive.compactor.initiator.on{noformat}
> So there is no way to selectively disable initiator and enable cleaner or 
> vice versa.
> Introducing another config to handle Cleaner thread alone like 
> hive.compactor.cleaner.on



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to