[ https://issues.apache.org/jira/browse/HIVE-26922?focusedWorklogId=838728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838728 ]
ASF GitHub Bot logged work on HIVE-26922: ----------------------------------------- Author: ASF GitHub Bot Created on: 11/Jan/23 20:01 Start Date: 11/Jan/23 20:01 Worklog Time Spent: 10m Work Description: amansinha100 commented on code in PR #3934: URL: https://github.com/apache/hive/pull/3934#discussion_r1067357268 ########## ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java: ########## @@ -3122,7 +3117,19 @@ Seems much cleaner if each stmt is identified as a particular HiveOperation (whi } return lockComponents; } - + + private static LockType getLockTypeFromStorageHandler(WriteEntity output, Table t) { + final HiveStorageHandler storageHandler = Preconditions.checkNotNull(t.getStorageHandler(), + "Thought all the non native tables have an instance of storage handler"); Review Comment: 'Thought' is misplaced here. Although this was in the original code too, this should be rephrased..something like 'Non native tables should have an instance of storage handler'. ########## iceberg/iceberg-handler/src/test/queries/positive/mv_iceberg_orc2.q: ########## @@ -22,3 +22,12 @@ select * from mat1; explain cbo select tbl_ice.b, tbl_ice.c from tbl_ice where tbl_ice.c > 52; + +insert into tbl_ice values (10, 'ten', 60); Review Comment: In addition to the INSERT test, can we add one for DELETE as well ? This would need format-version=2 for the source table. Also, I assume v2 is supported for the MV itself so having a sanity test where the MV is created with format-version=2 would be useful to check no deadlocks occur in that case. Issue Time Tracking ------------------- Worklog Id: (was: 838728) Time Spent: 0.5h (was: 20m) > Deadlock when rebuilding Materialized view stored by Iceberg > ------------------------------------------------------------ > > Key: HIVE-26922 > URL: https://issues.apache.org/jira/browse/HIVE-26922 > Project: Hive > Issue Type: Bug > Reporter: Krisztian Kasa > Assignee: Krisztian Kasa > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > {code} > create table tbl_ice(a int, b string, c int) stored by iceberg stored as orc > tblproperties ('format-version'='1'); > insert into tbl_ice values (1, 'one', 50), (2, 'two', 51), (3, 'three', 52), > (4, 'four', 53), (5, 'five', 54); > create materialized view mat1 stored by iceberg stored as orc tblproperties > ('format-version'='1') as > select tbl_ice.b, tbl_ice.c from tbl_ice where tbl_ice.c > 52; > insert into tbl_ice values (10, 'ten', 60); > alter materialized view mat1 rebuild; > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)