[ https://issues.apache.org/jira/browse/HIVE-26802?focusedWorklogId=839896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839896 ]
ASF GitHub Bot logged work on HIVE-26802: ----------------------------------------- Author: ASF GitHub Bot Created on: 18/Jan/23 10:04 Start Date: 18/Jan/23 10:04 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3882: URL: https://github.com/apache/hive/pull/3882#discussion_r1073331086 ########## itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CliConfigs.java: ########## @@ -236,7 +240,39 @@ public MiniLlapLocalCliConfig() { } } } + + public static class MiniLlapLocalCompactorCliConfig extends AbstractCliConfig { + + public MiniLlapLocalCompactorCliConfig() { + super(CoreCliDriver.class); + try { + setQueryDir("ql/src/test/queries/clientpositive"); + + includesFrom(testConfigProps, "compaction.query.files"); + setResultsDir("ql/src/test/results/clientpositive/llap"); + setLogDir("itests/qtest/target/qfile-results/clientpositive"); + + setInitScript("q_test_init.sql"); + setCleanupScript("q_test_cleanup.sql"); + + setHiveConfDir("data/conf/llap"); + setClusterType(MiniClusterType.LLAP_LOCAL); + setCustomConfigValueMap(createConfVarsStringMap()); + } catch (Exception e) { + throw new RuntimeException("can't construct cliconfig", e); + } + } + private static Map<HiveConf.ConfVars, String> createConfVarsStringMap() { + Map<HiveConf.ConfVars,String> customConfigValueMap = new HashMap<>(); + customConfigValueMap.put(HiveConf.ConfVars.HIVE_EXECUTION_ENGINE, "tez"); Review Comment: 1. Why do we need to explicitly set the exec engine? isn't it already TEZ 2. What if we want to create tests for the MR compaction, I think that one should stay default. In q-tests, we can change to query-based. WDYT? Issue Time Tracking ------------------- Worklog Id: (was: 839896) Time Spent: 5h (was: 4h 50m) > Create qtest running QB compaction queries > ------------------------------------------ > > Key: HIVE-26802 > URL: https://issues.apache.org/jira/browse/HIVE-26802 > Project: Hive > Issue Type: Improvement > Reporter: Zoltán Rátkai > Assignee: Zoltán Rátkai > Priority: Minor > Labels: pull-request-available > Time Spent: 5h > Remaining Estimate: 0h > > Create a qtest that runs the queries that query-based compaction runs. > Not so much to check for correct data but more to check the query plans, to > simplify tracing changes in compilation that might affect QB compaction. -- This message was sent by Atlassian Jira (v8.20.10#820010)