[ 
https://issues.apache.org/jira/browse/HIVE-26952?focusedWorklogId=844394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844394
 ]

ASF GitHub Bot logged work on HIVE-26952:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/Feb/23 16:23
            Start Date: 08/Feb/23 16:23
    Worklog Time Spent: 10m 
      Work Description: tarak271 commented on code in PR #3959:
URL: https://github.com/apache/hive/pull/3959#discussion_r1100380431


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -1363,7 +1366,7 @@ public enum ConfVars {
         "hive.metastore.stats.auto.analyze.worker.count", 1,
         "Number of parallel analyze commands to run for background stats 
update."),
     STORAGE_SCHEMA_READER_IMPL("metastore.storage.schema.reader.impl", 
"metastore.storage.schema.reader.impl",
-        DEFAULT_STORAGE_SCHEMA_READER_CLASS,
+        SERDE_STORAGE_SCHEMA_READER_CLASS,

Review Comment:
   Code flow 
   
https://github.com/apache/hive/blob/cdf34923122c5bd6f3fda8153a3e53b9ff051d88/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java#L6300
   will not go through storage serde for formats listed at 
   
https://github.com/apache/hive/blob/cdf34923122c5bd6f3fda8153a3e53b9ff051d88/standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java#L1304
   
   I have validated for Avro and storage handler type formats like HBase, JDBC





Issue Time Tracking
-------------------

    Worklog Id:     (was: 844394)
    Time Spent: 1.5h  (was: 1h 20m)

> set the value of metastore.storage.schema.reader.impl
 to 
> org.apache.hadoop.hive.metastore.SerDeStorageSchemaReader as default
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-26952
>                 URL: https://issues.apache.org/jira/browse/HIVE-26952
>             Project: Hive
>          Issue Type: Improvement
>          Components: Standalone Metastore
>            Reporter: Taraka Rama Rao Lethavadla
>            Assignee: Taraka Rama Rao Lethavadla
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> With the default value of
>  
> {code:java}
> DefaultStorageSchemaReader.class.getName(){code}
>  
> in the Metastore Config, *metastore.storage.schema.reader.impl*
> below exception is thrown when trying to read Avro schema
> {noformat}
> Caused by: org.apache.hive.service.cli.HiveSQLException: MetaException 
> (message:java.lang.UnsupportedOperationException: Storage schema reading not 
> supported)
>     at 
> org.apache.hive.service.cli.operation.GetColumnsOperation.runInternal(GetColumnsOperation.java:213)
>     at org.apache.hive.service.cli.operation.Operation.run(Operation.java:247)
>     at 
> org.apache.hive.service.cli.session.HiveSessionImpl.getColumns(HiveSessionImpl.java:729)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at 
> org.apache.hive.service.cli.session.HiveSessionProxy.invoke(HiveSessionProxy.java:78)
>     at 
> org.apache.hive.service.cli.session.HiveSessionProxy.access-zsh(HiveSessionProxy.java:36)
>     at 
> org.apache.hive.service.cli.session.HiveSessionProxy.run(HiveSessionProxy.java:63)
>     at java.security.AccessController.doPrivileged(Native Method)
>     at javax.security.auth.Subject.doAs(Subject.java:422)
>     at 
> org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1730)
>     at 
> org.apache.hive.service.cli.session.HiveSessionProxy.invoke(HiveSessionProxy.java:59)
>     at com.sun.proxy..getColumns(Unknown Source)
>     at 
> org.apache.hive.service.cli.CLIService.getColumns(CLIService.java:390){noformat}
> setting the above config with 
> *org.apache.hadoop.hive.metastore.SerDeStorageSchemaReader* resolves issue
> Proposing to make this value as default in code base, so that in upcoming 
> versions we don't have to set this value manually



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to