[ 
https://issues.apache.org/jira/browse/HIVE-25032?focusedWorklogId=845292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845292
 ]

ASF GitHub Bot logged work on HIVE-25032:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Feb/23 06:51
            Start Date: 14/Feb/23 06:51
    Worklog Time Spent: 10m 
      Work Description: saihemanth-cloudera commented on code in PR #4028:
URL: https://github.com/apache/hive/pull/4028#discussion_r1105360251


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -2174,6 +2174,22 @@ List<Partition> dropPartitions(String catName, String 
dbName, String tblName,
                                  PartitionDropOptions options)
       throws NoSuchObjectException, MetaException, TException;
 
+  /**
+   * @param catName catalog name
+   * @param dbName Name of the database
+   * @param tblName Name of the table
+   * @param partNames Arrays of partitions to drop
+   * @param options Boolean options for dropping partitions
+   * @return List of Partitions dropped
+   * @throws NoSuchObjectException No partition matches the expression(s), and 
ifExists was false.
+   * @throws MetaException error access the RDBMS or storage.
+   * @throws TException On failure
+   */
+  List<Partition> dropPartitions(String catName, String dbName, String tblName,
+                                 String[] partNames,

Review Comment:
   Why do we want to declare this as String array? We are anyway using 
List<String> everywhere, right?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 845292)
    Time Spent: 2h 40m  (was: 2.5h)

> Optimise PartitionManagementTask
> --------------------------------
>
>                 Key: HIVE-25032
>                 URL: https://issues.apache.org/jira/browse/HIVE-25032
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajesh Balamohan
>            Assignee: Zhihua Deng
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> When large number of tables and dbs are present, it takes lot of time to 
> iterate over all tables in PartitionManagementTask.
> If table parameters are populated in TableMeta, it will cut down lots of 
> interactions with HMS in PartitionManagementTask.
>  
> Code Ref:
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionManagementTask.java#L126]
>  
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartitionManagementTask.java#L132]
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to