[ https://issues.apache.org/jira/browse/HIVE-27031?focusedWorklogId=845309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-845309 ]
ASF GitHub Bot logged work on HIVE-27031: ----------------------------------------- Author: ASF GitHub Bot Created on: 14/Feb/23 08:41 Start Date: 14/Feb/23 08:41 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #4026: URL: https://github.com/apache/hive/pull/4026#discussion_r1105469275 ########## ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java: ########## @@ -145,11 +163,38 @@ private void reparseAndSuperAnalyze(ASTNode tree, Table mTable, ASTNode tabNameN where = (ASTNode)children.get(whereIndex); assert where.getToken().getType() == HiveParser.TOK_WHERE : "Expected where clause, but found " + where.getName(); - } - // Add a sort by clause so that the row ids come out in the correct order - appendSortBy(rewrittenQueryStr, columnAppender.getSortKeys()); + if (shouldOverwrite) { + if (where.getChildCount() == 1) { + + // Add isNull check for the where clause condition, since null is treated as false in where condition and + // not null also resolves to false, so we need to explicitly handle this case. + ASTNode functionNode = new ASTNode(new CommonToken(HiveParser.TOK_FUNCTION, "TOK_FUNCTION")); Review Comment: 👍 Issue Time Tracking ------------------- Worklog Id: (was: 845309) Time Spent: 5h (was: 4h 50m) > Iceberg: Implement Copy-On-Write for Delete Queries > --------------------------------------------------- > > Key: HIVE-27031 > URL: https://issues.apache.org/jira/browse/HIVE-27031 > Project: Hive > Issue Type: Sub-task > Reporter: Ayush Saxena > Assignee: Ayush Saxena > Priority: Major > Labels: pull-request-available > Time Spent: 5h > Remaining Estimate: 0h > > Implement copy on write mode for deletes for iceberg tables -- This message was sent by Atlassian Jira (v8.20.10#820010)