[ 
https://issues.apache.org/jira/browse/HIVE-26735?focusedWorklogId=848636&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848636
 ]

ASF GitHub Bot logged work on HIVE-26735:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Mar/23 11:24
            Start Date: 02/Mar/23 11:24
    Worklog Time Spent: 10m 
      Work Description: veghlaci05 commented on code in PR #4077:
URL: https://github.com/apache/hive/pull/4077#discussion_r1122947611


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -1561,7 +1561,7 @@ public void commitTxn(CommitTxnRequest rqst) throws 
NoSuchTxnException, TxnAbort
           assert true;
         }
 
-        if (txnType != TxnType.READ_ONLY && !isReplayedReplTxn) {
+        if (txnType != TxnType.READ_ONLY && !isReplayedReplTxn && txnType != 
TxnType.COMPACTION && txnType != TxnType.REBALANCE_COMPACTION) {

Review Comment:
   Only for rebalance compactions the components should not be moved. It is 
required to detect (and re-execute with a new plan) concurrent write attempts. 
Without this, even if a concurrent delete is blocked until rebalance happens, 
after obtaining the lock it would be executed on an old plan which is no longer 
valid. We need to force concurrent write attempts to re-create their plan 
before proceeding with the execution.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 848636)
    Time Spent: 2h  (was: 1h 50m)

> Ability to sort the data during rebalancing compaction
> ------------------------------------------------------
>
>                 Key: HIVE-26735
>                 URL: https://issues.apache.org/jira/browse/HIVE-26735
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: László Végh
>            Assignee: László Végh
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Ability to sort the data during rebalancing compaction



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to