[
https://issues.apache.org/jira/browse/HIVE-27180?focusedWorklogId=853322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853322
]
ASF GitHub Bot logged work on HIVE-27180:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Mar/23 07:25
Start Date: 28/Mar/23 07:25
Worklog Time Spent: 10m
Work Description: rtrivedi12 commented on code in PR #4159:
URL: https://github.com/apache/hive/pull/4159#discussion_r1150138782
##########
hcatalog/core/src/test/java/org/apache/hive/hcatalog/data/TestJsonSerDe.java:
##########
@@ -1,358 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.hive.hcatalog.data;
-
-import java.io.UnsupportedEncodingException;
-import java.math.BigDecimal;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-import java.util.Properties;
-
-import org.apache.hadoop.conf.Configuration;
-import org.apache.hadoop.hive.common.type.Date;
-import org.apache.hadoop.hive.common.type.HiveChar;
-import org.apache.hadoop.hive.common.type.HiveDecimal;
-import org.apache.hadoop.hive.common.type.HiveVarchar;
-import org.apache.hadoop.hive.common.type.Timestamp;
-import org.apache.hadoop.hive.conf.HiveConf;
-import org.apache.hadoop.hive.serde.serdeConstants;
-import org.apache.hadoop.io.Text;
-import org.apache.hadoop.io.Writable;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-
-import static org.junit.Assert.assertTrue;
-import org.junit.Test;
-
-/**
- * TestJsonSerDe.
- */
-public class TestJsonSerDe {
Review Comment:
We have another extensive test suite TestJsonSerDe under
org.apache.hadoop.hive.serde2 for testing the new implementation covering all
test scenarios.
Issue Time Tracking
-------------------
Worklog Id: (was: 853322)
Time Spent: 1h 10m (was: 1h)
> Remove JsonSerde from hcatalog, Upgrade should update changed FQN for
> JsonSerDe in HMS DB
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-27180
> URL: https://issues.apache.org/jira/browse/HIVE-27180
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Riju Trivedi
> Assignee: Riju Trivedi
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> As Hcatalog JsonSerDe uses the "serde2" version as a back end, Remove
> o{*}rg.apache.hive.hcatalog.data.JsonSerDe{*} from hive-hcatalog. Fix tests
> to use the new Serde class org.apache.hadoop.hive.serde2.JsonSerDe. Hive
> Upgrade schema script can update the SERDES table to alter the class name to
> the new class name, the old tables would work automatically.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
